Source server support for Hg builds requires PDBSTR_PATH to be set in the environment, pointing to pdbstr.exe. This is set here for Tinderbox builds on 1.9.0: http://mxr.mozilla.org/mozilla/source/tools/tinderbox-configs/firefox/win32/tinder-config.pl#14

I gave this a quick go in staging and it seemed to work OK - the .txt file that sits with the symbols had a bunch of: pdbstr -r/w -p:PdbFileName -i:StreamFileName -s:StreamName in it. Strangely though, the Firefox 3.0 ones don't have anything like this. I tried to test this out but I have no idea how to make windbg work.

Comment on attachment 392703 [details] [diff] [review] add PDBSTR_PATH to production, staging, try builders This looks reasonable, but having those pdbstr command lines wind up in the -symbols.txt is definitely not right. We should figure out what's happening there before landing this.

Is there anything in the .txt or logs, or any other place that we can verify it is working before checking this in?

Oops, I told you on IRC that I put info in the bug, but it was the wrong bug! Check bug 440001 comment 19 for a commandline that you can use to check the info contained in the PDB files.

Here's an updated graph: http://graphs-stage.mozilla.org/graph.html#tests=[{%22test%22:%2236%22,%22branch%22:%221%22,%22machine%22:%22271%22},{%22test%22:%2236%22,%22branch%22:%223%22,%22machine%22:%22271%22},{%22test%22:%2236%22,%22branch%22:%224%22,%22machine%22:%22271%22},{%22test%22:%2236%22,%22branch%22:%228%22,%22machine%22:%22271%22},{%22test%22:%2212%22,%22branch%22:%221%22,%22machine%22:%22271%22},{%22test%22:%2212%22,%22branch%22:%222%22,%22machine%22:%22271%22},{%22test%22:%2212%22,%22branch%22:%223%22,%22machine%22:%22271%22},{%22test%22:%2212%22,%22branch%22:%224%22,%22machine%22:%22271%22},{%22test%22:%2212%22,%22branch%22:%226%22,%22machine%22:%22271%22},{%22test%22:%2212%22,%22branch%22:%228%22,%22machine%22:%22271%22},{%22test%22:%2212%22,%22branch%22:%228%22,%22machine%22:%22268%22},{%22test%22:%2236%22,%22branch%22:%228%22,%22machine%22:%22268%22},{%22test%22:%2236%22,%22branch%22:%221%22,%22machine%22:%22268%22},{%22test%22:%2236%22,%22branch%22:%223%22,%22machine%22:%22268%22},{%22test%22:%2212%22,%22branch%22:%222%22,%22machine%22:%22268%22},{%22test%22:%2212%22,%22branch%22:%224%22,%22machine%22:%22268%22}]&sel=1249575272,1250848002 Things are still looking good, although the XP machine has few data points before OPSI was installed.

oops, wrong bug

Probably not getting to this soon.

Figured out the root cause, bug 520141.

I hear this is slowing down finding out more about our top-crashes, we should jump on this ASAP! Ideally we'd get this in for 3.5.4, even.

ted, bhearsum: whats left to do here? Set this env.variable and install pdbstr.exe on all the slaves? Is this going ok in staging?

This is nominated for blocking the already late 1.9.1 branch, but it's assigned to nobody and in the component "RelEng: Future" neither of which is very confidence building.

I'm not really sure what needs to be done here. I believe that my patch is needed, but it sounds like we need bug 520141 before anything will work.

Yeah, we need bug 520141 on trunk, 1.9.2, 1.9.1, and then we need Ben's patch.

So I talked to peterv about this and it's not *critical* to get this in for 3.5.4, but we should still get this fixed ASAP, and if we can do it for 3.5.4 w/o delaying it further, I think we should at least try...

Ben: I just landed bug 520141 on m-c. When you get a chance, could you land just the m-c portion of this patch? I think landing the whole thing will break branches I haven't landed on, but I want to get a nightly out with both of our patches to verify that it's working right.

Landed m-c part: http://hg.mozilla.org/build/buildbot-configs/rev/d1050f6f72e5 and reconfig'd pm.

And fixed the path http://hg.mozilla.org/build/buildbot-configs/rev/75f3e43b2a11

Comment on attachment 392703 [details] [diff] [review] add PDBSTR_PATH to production, staging, try builders Approved for 1.9.1.4, a=dveditz for release-drivers This must land today, Oct 5, because we will be doing builds tomorrow morning.

This needs to land on 1.9.2 as well.

pm, pm02 and try reconfigured to pick up 79479c0ab82c.