User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1.3pre) Gecko/20090731 Shiretoko/3.5.3pre Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1.3pre) Gecko/20090802 Shredder/3.0b4pre This may have been a bug all along but it was mighty handy;) Until not too long ago, when I saved a message as a file from Thunderbird and type an extension w/o changing the file type dropdown list, I got the intended file type. For example, I choose 'Save As' For a given message and type the name as "out.htm'; leave the "Save As" dropdown list as "Mail files". Then I look at the file and it’s a vaild html file. Now when I do the above, I get a file that renders hooribly in the browser but is not associated with Thunderbird. I can open it with thunderbird though and it renders correctly. On the other hand, if I just change the "Save As" dropdown to HTML, the file extension is not changed and the file has "eml" extension. Opening this file in the browser renders correctly. Ideally the old behavior should be restored (i.e. if I set the file extension, use that). But if not, then at least if you set the "Save As" dropdown to HTML file type, then the extension on the file should be changed to a valid html file extension. Reproducible: Always Steps to Reproduce: See above. Both cases are laid out. Actual Results: Described in Details Expected Results: Described in details. I tried searching for equiv bug. Others about file ext but could not find one like this.

confirming.

xref bug 509379 on XP

Looking at this and bug 509379, I'm think it could be worth doing a straight back out of bug 340168. If we want to fix the dataloss issue for TB 3 then I would suggest one of: 1) don't append .eml onto the file name - if the user doesn't add it, tough, it doesn't get added. 2) Try and add .eml but if the file exists then revert to the version without .eml. We can then file a follow-up bug to fix the issue in a OS consistent way in slower time. Thoughts?

(In reply to comment #3) > 1) don't append .eml onto the file name - if the user doesn't add it, tough, it > doesn't get added. So we reintroduce the All Files save as type and detection based on the extension, but don't attempt to add an extension if one isn't already there? Sounds fine I guess.

(In reply to comment #4) > (In reply to comment #3) > > 1) don't append .eml onto the file name - if the user doesn't add it, tough, it > > doesn't get added. > > So we reintroduce the All Files save as type and detection based on the > extension, but don't attempt to add an extension if one isn't already there? > Sounds fine I guess. I'm thinking that may be the simplest way to go for now to get around the dataloss issue, the follow-up bug can remove the all files in some sane way for all OSes.

As discussed above, this reintroduces the All Files type and file type detection based on the extension. This doesn't add extensions, so we should still be able to avoid data loss. Tested and works fine on Windows 7, Windows XP, Linux, and OS X.

Try builds! Linux: http://s3.mozillamessaging.com/build/try-server/2009-08-30_07:31-sid.bugzilla@gmail.com-1251642073/sid.bugzilla@gmail.com-1251642073-mail-try-linux.tar.bz2 Mac: http://s3.mozillamessaging.com/build/try-server/2009-08-30_07:31-sid.bugzilla@gmail.com-1251642073/sid.bugzilla@gmail.com-1251642073-mail-try-mac.dmg Windows installer: http://s3.mozillamessaging.com/build/try-server/2009-08-30_07:31-sid.bugzilla@gmail.com-1251642073/sid.bugzilla@gmail.com-1251642073-mail-try-win32.installer.exe Windows zip: http://s3.mozillamessaging.com/build/try-server/2009-08-30_07:31-sid.bugzilla@gmail.com-1251642073/sid.bugzilla@gmail.com-1251642073-mail-try-win32.zip

Thanks! All is working perfectly on Windows. On Mac there is one minor issue when you change the Output Type dropdown as described below. I did not test Linux. Working awesome on Windows - with Output Type = All Files, file type generated is based on extension and correct. - When changing Output Type, the file extension is automatically changed and output is correct type Note: If you override the file ext with Output Type selected, you get the file type for Output Type, not the extension. This is expected. With Mac: - With Output Type = All Files, file type is based on extension and correct - If you change Output Type, the file extension is not changed but the output type still written correctly So remaining issue on Mac is: If you change output type, the file extension should be updated to match. Hope that is clear. Let me know if not.

(In reply to comment #8) > Thanks! > All is working perfectly on Windows. On Mac there is one minor issue when you > change the Output Type dropdown as described below. I did not test Linux. > > Working awesome on Windows > - with Output Type = All Files, file type generated is based on extension and > correct. > - When changing Output Type, the file extension is automatically changed and > output is correct type > Note: If you override the file ext with Output Type selected, you get the file > type for Output Type, not the extension. This is expected. I'm guessing this is Windows Vista or 7? > > With Mac: > - With Output Type = All Files, file type is based on extension and correct > - If you change Output Type, the file extension is not changed but the output > type still written correctly > > So remaining issue on Mac is: > If you change output type, the file extension should be updated to match. Yeah, unfortunately this is a core bug. I'll get around to filing it once this is out of the way.

Comment on attachment 397526 [details] [diff] [review] reintroduce the All Files type, v1 Yep, I think this is the right way to go. As you already said you would do, please ensure there is a bug on the Mac issue. r/sr=Standard8

Good guess on the OS. Its Windows 7. I should have mentioned I was using a yet unreleased OS :) Thanks for the info about Mac, The remaining issue is a minor point anyway. Thanks for the fix!

Comment on attachment 397526 [details] [diff] [review] reintroduce the All Files type, v1 ok

Filed bug 514491 for the Mac issue, and bug 514497 to keep track of things in general (Mac/Linux/XP).