Closed
Bug 509095
Opened 15 years ago
Closed 15 years ago
wget-en-US broken with mozilla-central, empty $(_ABS_DIST)
Categories
(Thunderbird :: Build Config, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.0b4
People
(Reporter: kairo, Assigned: kairo)
References
Details
Attachments
(1 file)
(deleted),
patch
|
standard8
:
review+
|
Details | Diff | Splinter Review |
On the new Thunderbird L10n repack builds, the wget-en-US step is broken for Macs on the comm-central + mozilla-central configuration with an empty $(_ABS_DIST)
This happens because packager.mk nowadays re-sets that var for Mac and on mozilla-central uses core_abspath for it, but the comm-central config.mk doesn't define core_abspath yet.
For now, we can paper over this by setting it in mail/locales/Makefile.in, but we probably want to do things right and port bug 483856 to comm-central at least after we branch.
Assignee | ||
Comment 1•15 years ago
|
||
Mark, are you OK with wallpapering over this problem this way for now? SeaMonkey more or less inadvertently does the same (I added the definition at the same place it is there).
We probably should file a bug for porting this the real way in config.mk, though, so we get it right at least after branching.
Attachment #393244 -
Flags: review?(bugzilla)
Comment 2•15 years ago
|
||
I've tried this on one of the failing os x l10n builders and it worked just fine.
Comment 3•15 years ago
|
||
Comment on attachment 393244 [details] [diff] [review]
set it in mail/locales/Makefile.in for now
I've not tested this, but as gozer has. r=Standard8 with a bug filed for the follow-up.
Attachment #393244 -
Flags: review?(bugzilla) → review+
Assignee | ||
Comment 4•15 years ago
|
||
Pushed as http://hg.mozilla.org/comm-central/rev/2a7b6871311b - follow-up is bug 509147.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Updated•15 years ago
|
Flags: in-testsuite-
Target Milestone: --- → Thunderbird 3.0b4
You need to log in
before you can comment on or make changes to this bug.
Description
•