Closed Bug 509147 Opened 15 years ago Closed 15 years ago

Port |Bug 483856 - Use $(CURDIR) to make pymake happy| to comm-central

Categories

(MailNews Core :: Build Config, defect)

Product:
MailNews Core
Component:
Build Config
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 3.1b2

People

(Reporter: kairo, Assigned: sgautherie)

References

Details

Attachments

(1 file, 1 obsolete file)

(Av2) Just copy it [Checkin: See comment 6]
(deleted), patch
standard8
: review+
Details | Diff | Splinter Review
As mentioned in bug 509095, it's OK to wallpaper over the lack of core_abspath in comm-central config.mk as long as our mainline is based on 1.9.1, but in the long run we probably want to do things right and port bug 483856 to comm-central (after we branch).
Blocks: C192ConfSync
Severity: normal → trivial
Depends on: 483856, 522211, 509095
Flags: in-testsuite-
Target Milestone: Future → ---
Depends on: 545085
Summary: Port bug 483856 to comm-central → Port |Bug 483856 - Use $(CURDIR) to make pymake happy| to comm-central
Assignee: nobody → sgautherie.bz
Status: NEW → ASSIGNED
Depends on: 521523, 533043, 463605
Target Milestone: --- → Thunderbird 3.1b1
*Copy bug 483856 itself. *PP_LOCALIZED_FILES part: was removed by TB bug 533043 and SM bug 521523. *core_abspath: undo TB bug 509095, SM+TB changeset a09a7d1c82d7 (bug 463605) and part of SB changeset b9ea76f33831.
Attachment #426993 - Flags: review?(bugzilla)
Comment on attachment 426993 [details] [diff] [review] (Av1) Just copy it, Remove previous c-c workaround(s) I did review all parts; but I'm not technically a mail/ or a calendar/ reviewer so leaving mark's request open.
Attachment #426993 - Flags: review+
Comment on attachment 426993 [details] [diff] [review] (Av1) Just copy it, Remove previous c-c workaround(s) This either needs a refresh or this is fixed now.
Attachment #426993 - Flags: review?(bugzilla)
What's left of patch Av1 after bug 545085 :-/
Attachment #426993 - Attachment is obsolete: true
Attachment #431064 - Flags: review?(bugzilla)
Comment on attachment 431064 [details] [diff] [review] (Av2) Just copy it [Checkin: See comment 6] >diff --git a/mail/base/Makefile.in b/mail/base/Makefile.in >--- a/mail/base/Makefile.in >+++ b/mail/base/Makefile.in >@@ -68,9 +68,8 @@ endif ... > include $(topsrcdir)/config/rules.mk >- Please drop this change, its unnecessary here. r=Standard8 without that.
Attachment #431064 - Flags: review?(bugzilla) → review+
Comment on attachment 431064 [details] [diff] [review] (Av2) Just copy it [Checkin: See comment 6] http://hg.mozilla.org/comm-central/rev/7353fbf8aafe Av2, with comment 5 suggestion(s).
Attachment #431064 - Attachment description: (Av2) Just copy it → (Av2) Just copy it [Checkin: See comment 6]
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: Thunderbird 3.1b1 → Thunderbird 3.1b2
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: