User-Agent: Mozilla/5.0 (X11; U; Linux i686; pl; rv:1.9.1.2) Gecko/20090729 Firefox/3.5.2 Build Identifier: In message header widget right now we have mail headers, common actions buttons and poorly positioned "other actions" button with really uncommon actions. Save as and view source actions can be both easily fired either by key combo or from main menu, there is no reason to put them in a header where the "space" is very limited. We should remove this button and save some vertical space. I have hard time when trying to figure out the scenario with these actions in every day usage and the vertical space in header is a very common complain. Reproducible: Always

The patch to reduce empty space on the bottom of the header widget. (it's far too big on linux, needs testing on mac and win)

(In reply to comment #0) > We should remove this button and save some vertical space. Bleh, s/vertical/horizontal/ - there are some issues when it is to narrow eg with lightning panel on the right and long headers or message face in message preview.

Yeah, I don't think it adds any value as is.

> Save as and view source actions can be both easily fired either by key combo or > from main menu, there is no reason to put them in a header where the "space" is > very limited. Part of the theory here is that menu bars at the top of the screen aren't as good as having UI affordances located visually close to the things they effect for discoverability reasons. > > We should remove this button and save some vertical space. > > Bleh, s/vertical/horizontal/ - there are some issues when it is to narrow eg > with lightning panel on the right and long headers or message face in message > preview. Part of the problem is the way the boxes are used for positioning. Exactly what we do here depends on where we end up in bug 499410, I suspect. I'll be poking at the more today. (In reply to comment #2) > Created an attachment (id=395388) [details] > additional patch > > The patch to reduce empty space on the bottom of the header widget. > (it's far too big on linux, needs testing on mac and win) Can you put up a before & after screenshot for linux?

(In reply to comment #5) > Can you put up a before & after screenshot for linux? The lower one header has the patch applied.

Comment on attachment 395388 [details] [diff] [review] additional patch (checked in) i only tested this on the Mac but it appears to be nothing but space saving. Thanks for the patch!

(In reply to comment #7) > i only tested this on the Mac but it appears to be nothing but space saving. Right, it should be, I will try to add today another one to bug 499410 for the upper-7px issue.

Comment on attachment 395388 [details] [diff] [review] additional patch (checked in) r=dmose; thanks for the patch!

Pushed to comm-central: <http://hg.mozilla.org/comm-central/rev/224c00db80db>.

Extensions-wise, we want the "other actions" button and it should not be removed; it is the only affordance of its type. Suggest re-titling the bug to just be about eliminating excess vertical waste in the header.

I would tend to agree. The option suggested in bug 511625 is an interesting one, however, that would trade away obviousness of usage for regaining a bunch of space.

(In reply to comment #11) > Extensions-wise, we want the "other actions" button and it should not be > removed; it is the only affordance of its type. Maybe, on the other hand it should be trivial to add the box/button even if will remove entire box, reserving space for some extensions that might add some actions someday is not convincing me and finally extensions can add actions to the button box, with trash like buttons to save horizontal space or with dropdown menubuttons as suggested in bug 511625 if really want to keep mountpoint for extensions, but we shouldn't display it unless we have good content to be placed there.

One more problem, signed messages...

(In reply to comment #14) > One more problem, signed messages... that is bug 464106

not sure why it un-assigned this. sorry!

Comment on attachment 395386 [details] [diff] [review] proposed patch Another of those "never finished header items". This hasn't offered any value since being added because we never got to filling in items that were interesting. If you check out some of the screenshots from bug 466025 you can see some of the other possible options that could have gone in. Open in tab/new window, Print, Mark Read / Unread. So as it is now there isn't much need to keep it but I'd rather plus a patch that improves the other actions area than removes it completely. It is a good place for extension developers to add other items like "Upload Attached Photos to Flickr" which would be hard to add in other places.

(In reply to comment #17) > It is a good > place for extension developers to add other items like "Upload Attached Photos > to Flickr" which would be hard to add in other places. Yes. I rather like keeping it. And to the last point above ... does seem better to me than an extension having to add it's own header line of actions, which would further reduce vertical space.

We've won back a goodly amount of vertical space in the header pane in other ways; we're not going to do this; resolving as WONTFIX for the core. It should be trivial to write an extension that applies a CSS rule of "display: none;" to the other actions button.