Closed
Bug 512934
Opened 15 years ago
Closed 15 years ago
runtests.py could produce a false configuration based on AVM path
Categories
(Tamarin Graveyard :: Build Config, defect)
Tamarin Graveyard
Build Config
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: brbaker, Assigned: brbaker)
Details
Attachments
(1 file)
|
(deleted),
patch
|
dschaffe
:
review+
|
Details | Diff | Splinter Review |
Incidentally I noticed a problem with the way this detection works. You can get
a false positive from the file/directory name which file(1) prints out by
default. Eg passing --avm=/opt/appcore/tamarin-redux/objdir-mips/shell/avmshell
would convince the script it was running on ppc(!). Modern versions of file(1)
have a -b option to suppress the filename output, but for portability there
should be something like this in runtestBase.py:
f = ' '.join(f)
+ f = f.replace(self.avm, '');
self.verbose_print('determineConfig: %s' % f)
|
Assignee | |
Comment 1•15 years ago
|
||
Prior to patch config is miscalcuated:
determineConfig: /c/temp/appcore/avmshell.exe: MS-DOS executable PE for MS Wind
ows (console) Intel 80386 32-bit
current configuration: ppc-win-tvm-release
With patch:
determineConfig: : MS-DOS executable PE for MS Windows (console) Intel 80386 32
-bit
current configuration: x86-win-tvm-release
Attachment #396987 -
Flags: review?(dschaffe)
|
||
Comment 2•15 years ago
|
||
Comment on attachment 396987 [details] [diff] [review]
remove the path information to asc
Looks fine. Hopefully someone does not set their AVM=CYGWIN_NT
Attachment #396987 -
Flags: review?(dschaffe) → review+
|
|
Assignee | |
Comment 3•15 years ago
|
||
patch pushed 2411:9324ad144e05
Assignee: nobody → brbaker
Status: NEW → RESOLVED
Closed: 15 years ago
Flags: flashplayer-triage+
Flags: flashplayer-qrb+
Resolution: --- → FIXED
|
|
Assignee | |
Updated•15 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•