Closed Bug 513018 Opened 15 years ago Closed 14 years ago

parseFloat accepts illegal number syntax

Categories

(Tamarin Graveyard :: Virtual Machine, defect, P2)

defect

Tracking

(Not tracked)

RESOLVED FIXED
Q3 11 - Serrano

People

(Reporter: brbaker, Assigned: lhansen)

References

Details

(Whiteboard: has-patch)

Attachments

(1 file, 1 obsolete file)

Steps to reproduce: trace(parseFloat("12..34..56")); (note the two decimal points between each pair of numbers) Actual Results: 1234.56 Expected Results, this is what firefox returns: 12 Transferred from JIRA ASC-3822 http://bugs.adobe.com/jira/browse/ASC-3822
Flags: flashplayer-triage+
Flags: flashplayer-qrb?
Assignee: nobody → rreitmai
Blocks: AS3_Builtins
Flags: flashplayer-qrb? → flashplayer-qrb+
Target Milestone: --- → flash10.1
Priority: -- → P2
Priority: P2 → P3
Priority: P3 → P4
Blocks: a2d-d2a
(Poaching.)
Assignee: rreitmai → lhansen
Note, not a duplicate of bug #510380.
Status: NEW → ASSIGNED
Summary: parseFloat does not return correct value → parseFloat accepts illegal number syntax
Attached patch Patch (obsolete) (deleted) — Splinter Review
(Patch will not land without the required discussion about versioning, pls review the code for functionality :-) The bug is that the number is scanned correctly, but then the information about where the scanning stopped is discarded and the string's length is incorrectly used during conversion to double. The patch changes to code so that it makes use of the information about the scanned length.
Attachment #407005 - Flags: review?(stejohns)
Whiteboard: Has patch
Attachment #407005 - Flags: review?(stejohns) → review+
Any fix for this would likely have to be version-checked for backwards compatibility.
Flags: in-testsuite?
Whiteboard: Has patch → Has patch; versioning
Flags: flashplayer-needsversioning+
Whiteboard: Has patch; versioning → Has patch
Assignee: lhansen → nobody
Priority: P4 → --
Target Milestone: flash10.1 → Future
This is a mass change. Every comment has "assigned-to-new" in it. I didn't look through the bugs, so I'm sorry if I change a bug which shouldn't be changed. But I guess these bugs are just bugs that were once assigned and people forgot to change the Status back when unassigning.
Status: ASSIGNED → NEW
Priority: -- → P2
Whiteboard: Has patch → has-patch
Target Milestone: Future → flash10.2
Assignee: nobody → lhansen
Depends on: 535770
Attachment #407005 - Attachment is obsolete: true
Attachment #465152 - Flags: review?(stejohns)
Status: NEW → ASSIGNED
Attachment #465152 - Flags: review?(stejohns) → review+
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Annotated the JIRA bug as well.
Flags: flashplayer-bug+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: