Closed
Bug 513906
Opened 15 years ago
Closed 15 years ago
Fix Decommit logic to handle vm_map recommit failure of partial block
Categories
(Tamarin Graveyard :: Garbage Collection (mmGC), defect, P1)
Tracking
(Not tracked)
VERIFIED
FIXED
flash10.1
People
(Reporter: treilly, Assigned: treilly)
Details
Attachments
(1 file)
(deleted),
patch
|
lhansen
:
superreview+
|
Details | Diff | Splinter Review |
Need to split into separate regions and forget about the block we couldn't recommit.
Flags: flashplayer-qrb+
Priority: -- → P2
Target Milestone: --- → flash10.1
Comment 1•15 years ago
|
||
See also bug #520080 - that too calls for an abstraction layer around commit/decommit.
Assignee | ||
Comment 2•15 years ago
|
||
Attachment #416453 -
Flags: superreview?(lhansen)
Comment 3•15 years ago
|
||
The use of "#if AVMSYSTEM_MAC" in GCHeap.h and GCHeap.cpp is incorrect; we must never test these names in normal code. "#ifdef MMGC_MAC" is what you want, since we're still using the MMGC_ prefix names in MMgc code. Otherwise AVMPLUS_MAC. See avmfeatures.as.
Please capitalize and punctuate the comment above the prototype for RemovePartialBlock in GCHeap.h.
Any particular reason the Region constructor needs to be inline?
In GCHeap.cpp, around line 1690 (the call to NewRegion), the new comment needs capitalization and punctuation. There is also a half-finished comment just before the else that must be completed.
In RemovePartialBlock, the 'goto' loop is really a 'while' loop (with the identical condition) and should be written as such.
In RemovePartialBlock, the variable 'newRegion' is never used.
Comment 4•15 years ago
|
||
Comment on attachment 416453 [details] [diff] [review]
implements RemovePartialBlock
Approved, provided changes are made to address those concerns.
Attachment #416453 -
Flags: superreview?(lhansen) → superreview+
Assignee | ||
Comment 5•15 years ago
|
||
fixed in tr 3291
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•