Closed
Bug 513955
Opened 15 years ago
Closed 15 years ago
Replace KL* APIs to TIS* APIs
Categories
(Core :: Widget: Cocoa, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9.3a1
People
(Reporter: masayuki, Assigned: masayuki)
References
Details
Attachments
(1 file, 4 obsolete files)
|
(deleted),
patch
|
jaas
:
review+
|
Details | Diff | Splinter Review |
nsChildView uses KL* APIs but they cannot be used for 64bit build.
We should replace them with TIS* APIs.
And also, we need to find the alternative of KeyTranslate, GetScriptManagerVariable and GetScriptVariable.
|
Assignee | |
Comment 1•15 years ago
|
||
(In reply to comment #0)
> And also, we need to find the alternative of KeyTranslate,
Looks like that uchar resource is always available of every keyboard layout on 10.5. So, we can drop the KCHR related block.
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•15 years ago
|
||
|
|
Assignee | |
Comment 3•15 years ago
|
||
Attachment #398674 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 4•15 years ago
|
||
Attachment #398824 -
Attachment is obsolete: true
Attachment #398844 -
Flags: review?(joshmoz)
|
|
Assignee | |
Comment 5•15 years ago
|
||
oops, the previous patch include a debug code, sorry for the spam.
Attachment #398844 -
Attachment is obsolete: true
Attachment #398845 -
Flags: review?(joshmoz)
Attachment #398844 -
Flags: review?(joshmoz)
|
|
Assignee | |
Comment 6•15 years ago
|
||
fix a mistake.
Attachment #398845 -
Attachment is obsolete: true
Attachment #398850 -
Flags: review?(joshmoz)
Attachment #398845 -
Flags: review?(joshmoz)
Comment on attachment 398850 [details] [diff] [review]
Patch v2.2
+ isRomanKeyboardLayout = kt.mScript == smRoman;
Use parens around the "==" operation to make this easier to read.
Thanks!
Attachment #398850 -
Flags: review?(joshmoz) → review+
|
|
Assignee | |
Comment 8•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
You need to log in
before you can comment on or make changes to this bug.
Description
•