Closed Bug 515009 Opened 15 years ago Closed 15 years ago

Ensure official branding and about:rights is not broken

Categories

(Thunderbird :: Build Config, defect)

defect
Not set
normal

Tracking

(blocking-thunderbird3.1 -)

RESOLVED WORKSFORME
Tracking Status
blocking-thunderbird3.1 --- -

People

(Reporter: standard8, Assigned: standard8)

References

(Depends on 1 open bug)

Details

mozilla-central is making some changes to how branding and official builds work on trunk and on 1.9.2. We need to make sure this doesn't break our builds or change how the official builds work. Minimum things to check are: - Builds with official branding set (correct names, logos etc) - about:rights (check official & non official builds have the correct details)
Flags: blocking-thunderbird3.1+
FWIW, none of the changes should affect Thunderbird. Bug 462598 just uses a different ifdef to control the content - can be done independently of bug 513025 (which should probably wait until bug 514817 is fixed). It depends on bug 514954, which is a purely additive change (and is now on both 1.9.2 and mozilla-central). Bug 514519 just removed some Firefox-specific code in configure, which also shouldn't have any impact on you.
(In reply to comment #0) > - about:rights (check official & non official builds have the correct details) The checkin of Bug 513023 has an affect to localized versions of Thunderbird 3.1a1. If you try to build your own localized version of TB3.1a at the moment, than it fails because of a missing aboutRights.dtd. So you have to copy aboutRights.dtd and aboutRights.properties from /mail/chrome/messenger to /toolkit/chrome/global to build it successfully.
(In reply to comment #2) > So you have to copy > aboutRights.dtd and aboutRights.properties from /mail/chrome/messenger to > /toolkit/chrome/global to build it successfully. I expect you mean within the locale directory. If so, this is because the locale hasn't been updated for the changes on trunk yet. As it is a locale issue I'm not concerned about that in this bug - just that en-US works correctly (and then locales will fall into place once they update).
(In reply to comment #3) > (In reply to comment #2) > > So you have to copy > > aboutRights.dtd and aboutRights.properties from /mail/chrome/messenger to > > /toolkit/chrome/global to build it successfully. > > I expect you mean within the locale directory. Yes, in the locale directory. And I'am also not really concernd about this. Once we will have a L10n dashboard for tb31x, localizers will see and fix this.
I don't think this really blocks alpha 1, and there's not currently an owner, so removing the target milestone. Switched flags to blocking-3.1: needed.
blocking-thunderbird3.1: --- → needed
Flags: blocking-thunderbird3.1+
Target Milestone: Thunderbird 3.1a1 → ---
Assignee: nobody → bugzilla
blocking-thunderbird3.1: needed → rc1+
This needs to be checked before beta 2 in case we need to fix strings. I'm pretty sure there's nothing to do however, but I still want to check.
blocking-thunderbird3.1: rc1+ → beta2+
Whiteboard: [needs a 1-2 hour examination]
Whiteboard: [needs a 1-2 hour examination] → [needs a 1-2 hour examination][may affect strings]
Depends on: 554359
No longer blocks: CcMcBuildIssues
No longer depends on: 462598, 514954
I've done try builds on all platforms and checked this through and I've not noticed any problems. Therefore resolving as WFM. I would still like to address bug 513025 at some stage, but that's not a blocker for 3.1b2.
Status: NEW → RESOLVED
blocking-thunderbird3.1: beta2+ → -
Closed: 15 years ago
Resolution: --- → WORKSFORME
Whiteboard: [needs a 1-2 hour examination][may affect strings]
You need to log in before you can comment on or make changes to this bug.