Closed
Bug 521764
Opened 15 years ago
Closed 14 years ago
[HTML5] Warn to error console when speculation fails
Categories
(Core :: DOM: HTML Parser, enhancement, P3)
Core
DOM: HTML Parser
Tracking
()
RESOLVED
FIXED
People
(Reporter: hsivonen, Assigned: hsivonen)
References
Details
Attachments
(1 file)
(deleted),
patch
|
sicking
:
review+
|
Details | Diff | Splinter Review |
When a speculation fails, emit a warning to error console (preferably with a link to an explanatory DevMo article) so that site authors can avoid speculation failures.
Assignee | ||
Updated•15 years ago
|
Priority: -- → P2
Assignee | ||
Updated•15 years ago
|
Priority: P2 → P3
Assignee | ||
Comment 1•14 years ago
|
||
I sent a deliberately broken parser that always failed speculations to the tryserver. On Mac, it was only 1% worse on tp4, but on Linux it was 13% worse on tp4 (both 32-bit and 64-bit).
While it's unlikely that a real site would have many scripts and fail speculation on every one, this result suggests that speculation failures may lead to measurable badness.
Note that the message is inaccurate until bug 535530 is fixed.
Assignee | ||
Comment 2•14 years ago
|
||
Windows falls between Mac and Linux (4% Windows 7, 8% XP)
This is a totally new type of warning that we've never done before. I.e. we're not warning about brokenness at all, but rather just warning about something that can possibly result in a performance hit.
I'm fine with putting this warning in, though I think we need to keep an eye out and if it's confusing people we need to remove it.
Attachment #452709 -
Flags: review?(jonas) → review+
Comment 4•14 years ago
|
||
One alternative could be to make this be a global notification that Firebug etc can then stick in a console or what not rather than putting this in the JS console.
Assignee | ||
Comment 5•14 years ago
|
||
Thanks. Landed: http://hg.mozilla.org/mozilla-central/rev/81ff228d9bd0
(In reply to comment #4)
> One alternative could be to make this be a global notification that Firebug etc
> can then stick in a console or what not rather than putting this in the JS
> console.
Filed bug 575538 about this.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•