Closed
Bug 997489
Opened 11 years ago
Closed 11 years ago
Lots of jsreftest warnings spam from '[JavaScript Warning: "An unbalanced tree was written using document.write() causing data from the network to be reparsed. For more information ...]'
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla31
People
(Reporter: emorley, Assigned: emorley)
References
Details
Attachments
(1 file)
(deleted),
patch
|
Waldo
:
review+
|
Details | Diff | Splinter Review |
eg: Android 4.0 Panda mozilla-inbound opt test jsreftest-1 on 2014-04-16 15:20:16 PDT for push 0d37b75f8cd3 https://tbpl.mozilla.org/php/getParsedLog.php?id=37959927&tree=Mozilla-Inbound 15:51:49 INFO - --------- beginning of /dev/log/main 15:51:49 INFO - 04-16 15:48:49.875 E/GeckoConsole( 2118): [JavaScript Warning: "An unbalanced tree was written using document.write() causing data from the network to be reparsed. For more information https://developer.mozilla.org/en/Optimizing_Your_Pages_for_Speculative_Parsing" {file: "http://10.12.131.19:30379/jsreftest/tests/jsreftest.html?test=js1_5/Regress/regress-334807-03.js" line: 15}] ... 15:51:49 INFO - 04-16 15:48:51.664 E/GeckoConsole( 2118): [JavaScript Warning: "An unbalanced tree was written using document.write() causing data from the network to be reparsed. For more information https://developer.mozilla.org/en/Optimizing_Your_Pages_for_Speculative_Parsing" {file: "http://10.12.131.19:30379/jsreftest/tests/jsreftest.html?test=js1_5/Regress/regress-334807-04.js" line: 15}] ... 15:51:49 INFO - 04-16 15:48:52.117 E/GeckoConsole( 2118): [JavaScript Warning: "An unbalanced tree was written using document.write() causing data from the network to be reparsed. For more information https://developer.mozilla.org/en/Optimizing_Your_Pages_for_Speculative_Parsing" {file: "http://10.12.131.19:30379/jsreftest/tests/jsreftest.html?test=js1_5/Regress/regress-334807-05.js" line: 15}] ... 15:51:49 INFO - 04-16 15:48:52.937 E/GeckoConsole( 2118): [JavaScript Warning: "An unbalanced tree was written using document.write() causing data from the network to be reparsed. For more information https://developer.mozilla.org/en/Optimizing_Your_Pages_for_Speculative_Parsing" {file: "http://10.12.131.19:30379/jsreftest/tests/jsreftest.html?test=js1_5/Regress/regress-334807-06.js" line: 15}] ... 15:51:49 INFO - 04-16 15:48:53.343 E/GeckoConsole( 2118): [JavaScript Warning: "An unbalanced tree was written using document.write() causing data from the network to be reparsed. For more information https://developer.mozilla.org/en/Optimizing_Your_Pages_for_Speculative_Parsing" {file: "http://10.12.131.19:30379/jsreftest/tests/jsreftest.html?test=js1_5/Regress/regress-336100.js" line: 15}] Henri, I'm guessing one of the document.write()s in https://mxr.mozilla.org/mozilla-central/source/js/src/tests/browser.js is messed up? Would you mind taking a look? :-)
Flags: needinfo?(hsivonen)
https://mxr.mozilla.org/mozilla-central/source/js/src/tests/browser.js#108 108 var s = "<tt>"+ string ; 109 s += "<b>" ; 110 s += ( passed ) ? "<font color=#009900> " + PASSED 111 : "<font color=#aa0000> " + FAILED + expect + "</tt>"; 112 113 DocumentWrite( s + "</font></b></tt><br>" ); 114 return passed; 115 } When |passed| is false, there is a stray </tt> tag.
Flags: needinfo?(hsivonen)
Assignee | ||
Comment 3•11 years ago
|
||
Fixes the console JS warning spam during jsreftests in comment 0. (Also... yuck @ the style inconsistency in this file)
Attachment #8408175 -
Flags: review?(jwalden+bmo)
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → emorley
Status: NEW → ASSIGNED
Comment 4•11 years ago
|
||
Comment on attachment 8408175 [details] [diff] [review] Fix stray </tt> tag causing JS warning spam during jsreftests Review of attachment 8408175 [details] [diff] [review]: ----------------------------------------------------------------- Not sure why me for this, but it's obvious and quick enough. :-)
Attachment #8408175 -
Flags: review?(jwalden+bmo) → review+
Assignee | ||
Comment 5•11 years ago
|
||
Thank you :-) remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/e733167dc8ac (In reply to Jeff Walden [:Waldo] (remove +bmo to email) from comment #4) > Not sure why me for this, but it's obvious and quick enough. :-) hg log
Assignee | ||
Updated•11 years ago
|
Component: Reftest → JavaScript Engine
Product: Testing → Core
Comment 6•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e733167dc8ac
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in
before you can comment on or make changes to this bug.
Description
•