Closed Bug 524089 Opened 15 years ago Closed 15 years ago

Create new Talos suite: Tsvg tests for group opacity perf

Categories

(Release Engineering :: General, defect, P2)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jwatt, Assigned: anodelman)

Details

Attachments

(6 files)

I have a couple of tests to add to check our performance handling group opacity in SVG.
This test hangs FF3.5 for about 30 seconds on my machine, but paints in under a second after the patch for bug 523481.
This test checks that we minimize the size of the offscreen surface that we create when group opacity can't reasonably be optimized away.
The first testcase should be added to mozilla-central Talos machines.

I'm not sure whether the second testcase should be added right now since it takes about 30 seconds to paint on my machine. Once we fix bug 309782 then it should also take less than a second.
Here's the link to new test creation docs:

https://wiki.mozilla.org/Testing/Talos/NewTests

You'd need to create a working talos patch that runs these tests as a first step.
Jonathan; once you have this test running on your box, let us know. We'll create a cloned VM for you that matches exactly what we build with, and then we can see if there are any hiccups running your patch on that.
Assignee: nobody → jwatt
Summary: Add new Tsvg tests for group opacity perf → Create new Talos suite: Tsvg tests for group opacity perf
Setting up as 'tsvg_opacity' test on staging.
Assignee: jwatt → anodelman
Priority: -- → P2
Attachment #410360 - Flags: review?(catlee) → review+
thanks!
Up and running on stage.
Attachment #410635 - Flags: review?(catlee)
Attachment #410635 - Flags: review?(catlee) → review+
Attachment #410865 - Flags: review?(lsblakk) → review+
Comment on attachment 410360 [details] [diff] [review]
[checked in]add new svg opacity test to graph server db

changeset:   251:323dd68178f1
Attachment #410360 - Attachment description: add new svg opacity test to graph server db → [checked in]add new svg opacity test to graph server db
Attachment #410360 - Flags: checked-in+
mysql> insert into pagesets values (NULL, "SVG Opacity");
Query OK, 1 row affected (0.01 sec)

mysql> insert into tests values (NULL,"tsvg_opacity","SVG, Opacity",1,1,9);
Query OK, 1 row affected (0.01 sec)

mysql> insert into tests values (NULL,"tsvg_opacity_nochrome","SVG, Opacity NoChrome",1,1,9);
Query OK, 1 row affected (0.01 sec)

mysql> insert into pages values (NULL,9,"small-group-opacity-2500.svg");
Query OK, 1 row affected (0.03 sec)

mysql> insert into pages values (NULL,9,"big-optimizable-group-opacity-2500.svg");
Query OK, 1 row affected (0.00 sec)

Changes pushed to production graph server.
Comment on attachment 410635 [details] [diff] [review]
[checked in]incorporate svg_opacity into talos

Checking in sample.config;
/cvsroot/mozilla/testing/performance/talos/sample.config,v  <--  sample.config
new revision: 1.36; previous revision: 1.35
done
RCS file: /cvsroot/mozilla/testing/performance/talos/page_load_test/svg_opacity/big-optimizable-group-opacity-2500.svg,v
done
Checking in page_load_test/svg_opacity/big-optimizable-group-opacity-2500.svg;
/cvsroot/mozilla/testing/performance/talos/page_load_test/svg_opacity/big-optimizable-group-opacity-2500.svg,v  <--  big-optimizable-group-opacity-2500.svg
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/testing/performance/talos/page_load_test/svg_opacity/small-group-opacity-2500.svg,v
done
Checking in page_load_test/svg_opacity/small-group-opacity-2500.svg;
/cvsroot/mozilla/testing/performance/talos/page_load_test/svg_opacity/small-group-opacity-2500.svg,v  <--  small-group-opacity-2500.svg
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/testing/performance/talos/page_load_test/svg_opacity/svg_opacity.manifest,v
done
Checking in page_load_test/svg_opacity/svg_opacity.manifest;
/cvsroot/mozilla/testing/performance/talos/page_load_test/svg_opacity/svg_opacity.manifest,v  <--  svg_opacity.manifest
initial revision: 1.1
done
Attachment #410635 - Attachment description: incorporate svg_opacity into talos → [checked in]incorporate svg_opacity into talos
Attachment #410635 - Flags: checked-in+
Comment on attachment 410865 [details] [diff] [review]
[checked in]incorporate svg tests into buildbot configs

changeset:   1722:ba563ea15c4a
Attachment #410865 - Attachment description: incorporate svg tests into buildbot configs → [checked in]incorporate svg tests into buildbot configs
Attachment #410865 - Flags: checked-in+
Up and reporting on all branches.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: