Open Bug 525225 Opened 15 years ago Updated 2 years ago

Re-add max-height (and scrollbar when necessary) to message pane normal mode

Categories

(Thunderbird :: Message Reader UI, defect)

defect

Tracking

(Not tracked)

People

(Reporter: BenB, Unassigned)

References

(Depends on 1 open bug)

Details

Attachments

(3 files)

+++ This is a split-off from bug 489609 +++ Bug 489609 "regressed" bug 511408 in normal headers mode, but it was intentional, see bug 489609 comment 14. It was a workaround for bug 492645. This bug is described in bug 489609 comment 71 and 72. This depends on bug 492645. Reproduction: 1. View | Headers | Normal 2. Open a message with a long subject, which spans more than one line. Actual result: The message header pane has a scrollbar, and the scrolling pane is only slightly larger than the visible pane, namely exactly as much as the second line of the subject. I.e. if the message pane needs 6 lines without wrapping, and 7 lines with wrapping, 6 lines are visible, and the last line in the header pane is only visible by scrolling down. That is although we specified in CSS that the header pane may grow up to 10 lines, and only then shall a scrollbar appear. That's bug 492645. Expected result: The whole message header is visible, no scroll bar, when when a line wraps. Only if the message header would grow larger than 14 or 20em, shall a scrollbar appear and the message pane have exactly that specified max-height.
Attached image Screenshot showing problem (deleted) —
I'm blocking bug 511408 as this may implement a partial solution to the problem described there.
Blocks: 511408
Attached patch Fix, v1 - depends on bug 492645 (deleted) — Splinter Review
As soon as bug 492645 is fixed, we could apply this and this bug would be gone.
Bug 525302 is a hacky workaround for this.
Severity: normal → major
Workaround bug 525302 checked in. I keep this open for trunk, because we want a better solution. That better solution will need: either 1) fix for bug 492645 2) rewrite of header pane in XHTML 3) another workaround (NOOO!! :-) )
Blocks: 77806
Severity: major → normal
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: