Extremely long subject cause that body panel doesn't appear - sanity check subject length
Categories
(Thunderbird :: Message Reader UI, defect)
Tracking
(thunderbird_esr78+ verified, thunderbird85 verified)
People
(Reporter: ji, Assigned: mkmelin)
References
(Depends on 2 open bugs, )
Details
(Keywords: testcase, uiwanted, Whiteboard: [gs])
Attachments
(8 files)
(deleted),
message/rfc822
|
Details | |
(deleted),
image/png
|
Details | |
(deleted),
message/rfc822
|
Details | |
(deleted),
image/png
|
Details | |
(deleted),
image/png
|
Details | |
(deleted),
image/png
|
Details | |
(deleted),
patch
|
Paenglab
:
review+
BenB
:
feedback+
wsmwk
:
approval-comm-beta+
wsmwk
:
approval-comm-esr78+
|
Details | Diff | Splinter Review |
(deleted),
image/png
|
Details |
Updated•24 years ago
|
Updated•23 years ago
|
Updated•20 years ago
|
Updated•16 years ago
|
Updated•16 years ago
|
Comment 4•15 years ago
|
||
Comment 5•15 years ago
|
||
Updated•14 years ago
|
Updated•13 years ago
|
Comment 8•13 years ago
|
||
Comment 9•13 years ago
|
||
Comment 10•13 years ago
|
||
Comment 11•13 years ago
|
||
Updated•13 years ago
|
Comment 12•12 years ago
|
||
Comment 13•12 years ago
|
||
Comment 14•12 years ago
|
||
Updated•12 years ago
|
Updated•12 years ago
|
Updated•12 years ago
|
Updated•12 years ago
|
Updated•12 years ago
|
Updated•12 years ago
|
Updated•12 years ago
|
Updated•12 years ago
|
Updated•12 years ago
|
Updated•12 years ago
|
Comment 15•12 years ago
|
||
Comment 16•12 years ago
|
||
Comment 17•12 years ago
|
||
Updated•12 years ago
|
Comment 18•12 years ago
|
||
Comment 19•12 years ago
|
||
Comment 20•12 years ago
|
||
Comment 21•12 years ago
|
||
Comment 22•12 years ago
|
||
Comment 23•12 years ago
|
||
Comment 24•12 years ago
|
||
Comment 25•12 years ago
|
||
Comment 26•12 years ago
|
||
Comment 27•12 years ago
|
||
Comment 28•12 years ago
|
||
Comment 29•12 years ago
|
||
Comment 30•11 years ago
|
||
Comment 31•11 years ago
|
||
Comment 33•9 years ago
|
||
Comment 35•7 years ago
|
||
Assignee | ||
Comment 36•4 years ago
|
||
Looks like this would need css line-clamp (bug 866102)
Assignee | ||
Comment 37•4 years ago
|
||
Oh, which is implemented!
Assignee | ||
Comment 38•4 years ago
|
||
Limit subject to max 3 lines, after which you get scrollbars instead.
Use https://bugzilla.mozilla.org/attachment.cgi?id=32356 to easily reproduce.
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Updated•4 years ago
|
Comment 39•4 years ago
|
||
Affects hovering over message list, but I'm not certain there is anything here to fix.
Comment 40•4 years ago
|
||
Comment on attachment 9194399 [details] [diff] [review]
bug77806_subject_height.patch
Looks a bit weird using -webkit- but there are no alternatives yet. Thanks.
Comment 41•4 years ago
|
||
Comment on attachment 9194399 [details] [diff] [review]
bug77806_subject_height.patch
Good approach and idea to use CSS only
I concur with Richard. At least the "box" should have a standard or -moz
alternative, leaving only -webkit-line-clamp
with webkit prefix. Can you please try whether these work together, and if so, use them?
Updated•4 years ago
|
Comment 42•4 years ago
|
||
(In reply to Ben Bucksch (:BenB) from comment #41)
Comment on attachment 9194399 [details] [diff] [review]
bug77806_subject_height.patchGood approach and idea to use CSS only
I concur with Richard. At least the "box" should have a standard or
-moz
alternative, leaving only-webkit-line-clamp
with webkit prefix. Can you please try whether these work together, and if so, use them?
I tried it, the -moz
alternative doesn't work.
Comment 43•4 years ago
|
||
Thanks for testing this, to both of you.
Assignee | ||
Comment 44•4 years ago
|
||
Yes unfortunately standards line-clamp is not yet implemented, only -webkit-line-clamp, for compatibility purposes. And that requires display: -webkit-box;
Comment 45•4 years ago
|
||
(In reply to Wayne Mery (:wsmwk) from comment #39)
Created attachment 9194403 [details]
hover message listAffects hovering over message list, but I'm not certain there is anything here to fix.
Imho the tooltip should also be cropped after a couple of lines.
Comment 46•4 years ago
|
||
That should be trivial, by limiting the tooltip to 500 characters:
el.tooltip = msg.subject.substr(0, 500);
(You cannot limit the tooltip to a number of lines, because it's native code, and CSS is not applicable. You don't know how large the screen is. A limit to a number of characters is a good enough approximation. Just make sure that it's long enough so any remotely close to normal subjects are not cut, only insane ones like Wayne showed. The tooltip is useful to show subjects that are too long for a line - that's the whole reason why we have the tooltip in the first place: to show overly long subjects.)
Comment 47•4 years ago
|
||
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/260b9ca429e3
limit the subject to max 3 lines, for more than that use scrollbars. r=Paenglab
Assignee | ||
Comment 48•4 years ago
|
||
This is the tooltip for a tree cell. I don't see exactly where we set it atm. Feel free to send a patch to fix it.
Assignee | ||
Comment 49•4 years ago
|
||
Comment on attachment 9194399 [details] [diff] [review]
bug77806_subject_height.patch
[Approval Request Comment]
User impact if declined: for extremely long subjects, message body can't be seen
Testing completed (on c-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): css only, not risky
Comment 50•4 years ago
|
||
Comment on attachment 9194399 [details] [diff] [review]
bug77806_subject_height.patch
[Triage Comment]
Approved for beta
Comment 51•4 years ago
|
||
bugherder uplift |
Thunderbird 85.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/39842adf700a
Comment 52•4 years ago
|
||
Used Testcase #2 in my testing of the 85.0b3 release candidate on Windows 10.
Saved the testcase.
Opened it and the Subject field had a scrollbar.
Opened a composition window and copied the subject and sent it to another account.
Opened the message and the Subject field had a scrollbar.
The tool tip showed the whole subject.
Comment 53•4 years ago
|
||
Comment on attachment 9194399 [details] [diff] [review]
bug77806_subject_height.patch
[Triage Comment]
Approved for esr78
Comment 54•4 years ago
|
||
bugherder uplift |
Thunderbird 78.6.1:
https://hg.mozilla.org/releases/comm-esr78/rev/9ae34847f12e
Updated•4 years ago
|
Description
•