Closed
Bug 532312
Opened 15 years ago
Closed 15 years ago
commands from other viewers should be disabled
Categories
(Other Applications :: DOM Inspector, defect)
Other Applications
DOM Inspector
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: surkov, Assigned: surkov)
References
Details
Attachments
(1 file)
(deleted),
patch
|
sdwilsh
:
review+
neil
:
superreview+
|
Details | Diff | Splinter Review |
For example, if I choose stylesheet viewer and click FindNode menuitem then I get an error:
Warning: reference to undefined property this.mViewerHash[aUID]
Source File: chrome://inspector/content/ViewerRegistry.js
Line: 203
Error: this.mViewerHash[aUID] is undefined
Source File: chrome://inspector/content/ViewerRegistry.js
Line: 203
Since these commands don't make a sense for viewers other than DOMNodes viewer (at this moment of course) then they should be disabled. Once they will be actual for other viewers as as well then they should be moved somewhere outside of DOMNodes viewer I think.
I think it's enough to remove 'exclusive' attribute check while viewer commands are updated. It sounds this attribute is an rudiment and is not used at all currently.
Attachment #415551 -
Flags: superreview?(neil)
Attachment #415551 -
Flags: review?(sdwilsh)
Updated•15 years ago
|
Attachment #415551 -
Flags: superreview?(neil) → superreview+
Comment 1•15 years ago
|
||
Maybe I'm misunderstanding, but it's not "enough to remove 'exclusive' attribute check". That just eliminates useless code, but additional checks still need to be written to fix this bug.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → DUPLICATE
Assignee | ||
Comment 2•15 years ago
|
||
(In reply to comment #1)
> Maybe I'm misunderstanding, but it's not "enough to remove 'exclusive'
> attribute check". That just eliminates useless code, but additional checks
> still need to be written to fix this bug.
I tried this works.
> *** This bug has been marked as a duplicate of bug 517709 ***
The bug 517709 summary is a bit different. But if they are the same then I think the older bug should be marked as duplicate of the newer bug in this case because the work has been started on a newer bug but an older one.
Comment 3•15 years ago
|
||
(In reply to comment #2)
> I tried this works.
Oops. I don't know why I was still getting errors before.
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Comment 6•15 years ago
|
||
Comment on attachment 415551 [details] [diff] [review]
patch
>+++ b/resources/content/inspector.xml
>+ if (aValue == false || aValue == "false")
Change these checks to === please.
r=sdwilsh with that change.
Attachment #415551 -
Flags: review?(sdwilsh) → review+
Assignee | ||
Comment 7•15 years ago
|
||
fixed by bug 532355
Status: REOPENED → RESOLVED
Closed: 15 years ago → 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•