The getElement method which has been added to the DownloadsAPI (bug 536278) to make it easier to retrieve elements from the Downloads Manager should be ported to other API's too. That will make tests much cleaner and will require much less update orgies when structures in the XUL or HTML code changes.

We should have a separate bug for each shared module. Using this bug for the addons API.

This has been gotten a bigger patch as expected. All changes lift the API to our current style now. I have also fixed broken tests which failed due to problems in the API.

This patch is dependent on patch 1 and fixes some leftovers. It also uses the preview website whenever possible. That way we do not mess around with download numbers and could even find regressions on AMO before they release a new version.

This is the combined patch from the above two patches. I will already attach it on that bug because I'm away tomorrow and give Anthony some time for the review. It works well on all my platforms locally.

I'm unable to apply the follow-up patch for the default branch. I pulled a new copy of the repository, applied the first patch, then applied the follow-up patch. The first patch applies ok, but the second patch fails like so: applying updateAddonsAPI2 patching file firefox/restartTests/testExtensionInstallGetAddons/test1.js patching file firefox/restartTests/testThemeInstallUninstall/test1.js patching file firefox/testAddons/testDisableEnablePlugin.js patching file firefox/testAddons/testSearchAddons.js patching file shared-modules/testAddonsAPI.js Hunk #1 FAILED at 7 1 out of 6 hunks FAILED -- saving rejects to file shared-modules/testAddonsAPI.js.rej patch failed to apply firefox/restartTests/testExtensionInstallGetAddons/test1.js firefox/restartTests/testThemeInstallUninstall/test1.js firefox/testAddons/testDisableEnablePlugin.js firefox/testAddons/testSearchAddons.js shared-modules/testAddonsAPI.js patch failed, rejects left in working dir errors during apply, please fix and refresh updateAddonsAPI2 Other than this, code looks fine.

The 1.9.1 patch also fails to apply on a new pull of the 1.9.1 branch: applying updateAddonsAPI cannot create firefox/restartTests/testExtensionInstallGetAddons/test1.js: destination already exists firefox/helperClasses/testAddonsAPI.js patch failed, rejects left in working dir errors during apply, please fix and refresh updateAddonsAPI Code looks fine otherwise.

Anthony, you should clean up your local repository before you apply any patches. Run a 'hg stat' to see which files have been modified locally. Both patches apply cleanly for me. Given your comments you are fine with the patches and gave a r+ in words. I will check those changes into our repository so the next test-run will show us the results.

Comment on attachment 440768 [details] [diff] [review] Follow-up v1 (default) r+ as given by comment 6.

Comment on attachment 440771 [details] [diff] [review] Patch v1 (mozilla1.9.1) r+ as given by comment 7.

Landed as: http://hg.mozilla.org/qa/mozmill-tests/rev/b26e11ac94c4 http://hg.mozilla.org/qa/mozmill-tests/rev/0f9535ee2387 http://hg.mozilla.org/qa/mozmill-tests/rev/ced1cfd9c481

(In reply to comment #7) > Anthony, you should clean up your local repository before you apply any > patches. Run a 'hg stat' to see which files have been modified locally. Both > patches apply cleanly for me. > I'm using a brand new pull of the repository to a new folder. I'm not modifying the .js files in the tree at all before applying the patch, so I don't understand why this would be considered "dirty" from initial pull unless there is something wrong in the repo. I'll take this issue to email.

Move of Mozmill Test related project bugs to newly created components. You can filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.