Closed
Bug 552913
Opened 15 years ago
Closed 14 years ago
[mozmill] Failure in testExtensionInstallationGetAddonsPane because of no pane switching
Categories
(Mozilla QA Graveyard :: Mozmill Tests, defect)
Mozilla QA Graveyard
Mozmill Tests
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: whimboo, Assigned: whimboo)
References
Details
(Whiteboard: [mozmill-test-failure])
Failure:
fail c:\Users\mozilla\mozmill\default\firefox\restartTests\testExtensionInstallationGetAddonsPane\test1.js testInstallExtension 8828 timeout exceeded for waitForEval('subject.getPane() == 'installs'')
When installing an extension via the Get Addons pane inside the Addons Manager, we do not switch the panes automatically. That's why we run this code:
// Check if the extension is visible in the installation pane
addonsManager.setPane("installs");
But something is wrong and the pane is not selected. This problem is visible on all platforms now.
Mark, I think this is not hard to fix. Would you like to have a look at?
Comment 1•15 years ago
|
||
...yep, I'll take it...
Comment 2•15 years ago
|
||
I found if I added a sleep in line 92 of test1.js, the script passes. Here it is in context...
// Check if the extension is visible in the installation pane
controller.sleep(5000);
addonsManager.setPane("installs");
.....
Assignee | ||
Comment 3•15 years ago
|
||
http://hg.mozilla.org/qa/mozmill-tests/file/27eb44884e3e/firefox/restartTests/testExtensionInstallationGetAddonsPane/test1.js#l81
Thanks for discovering that Mark. I can remember that we had the same problem a while back. Looks like we are too fast and don't wait until the add-on has been installed. setPane should be called when the notification bar pops down or the installationn status label mentions "Installed".
Assignee: nobody → marklocklear
Status: NEW → ASSIGNED
Assignee | ||
Comment 4•15 years ago
|
||
Mark, will you have time to continue on that bug? It will be a good challenge for you.
Comment 5•15 years ago
|
||
Sorry Henrik, I was thinking this was something you had to fix in some of the backend code. I will continue looking at it and see what I can come up with.
Assignee | ||
Updated•15 years ago
|
Whiteboard: [mozmill-test-failure]
Assignee | ||
Comment 6•15 years ago
|
||
Mark, would you mind when I take this bug? We will have to update the addonsAPI before we are really able to fix that bug. The reason is that we do not wait long enough for the installs pane. Due to the delayed installation when clicking the button we run into a timeout. It's happening because of the modal dialog handling.
Comment 7•15 years ago
|
||
Sure thing Henrik...I think this one is beyond be for now. Go ahead and fix it. I will be anxious to see how its fixed. Thanx for letting me take a crack at it...
Assignee | ||
Comment 8•15 years ago
|
||
Alright. Mark, we have a couple of other failures so feel free to select one of those.
Assignee: marklocklear → hskupin
Assignee | ||
Comment 9•15 years ago
|
||
This failure should get fixed by my patch on bug 536730. I can't reproduce it any longer with the patch applied.
Assignee | ||
Comment 10•14 years ago
|
||
Should be fixed now by the checkin of the patch on bug 536730.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 11•14 years ago
|
||
Mass move of Mozmill Test related project bugs to newly created components. You can filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.
Component: Add-ons Manager → Mozmill Tests
Product: Toolkit → Mozilla QA
QA Contact: add-ons.manager → mozmill-tests
Updated•5 years ago
|
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•