Closed
Bug 543271
Opened 15 years ago
Closed 10 years ago
rules.mk: remove "tier" support code (in SeaMonkey)
Categories
(SeaMonkey :: Build Config, defect)
SeaMonkey
Build Config
Tracking
(Not tracked)
VERIFIED
INVALID
People
(Reporter: sgautherie, Unassigned)
References
()
Details
I noticed this while checking
http://hg.mozilla.org/mozilla-central/rev/0cb6d4bc7eae
(no bug): Add echo-tier-dirs target, to display tiers' directories. r=bsmedberg
Callek) told me:
{
>> The only reference to tiers is from mozilla/ and our use of tiers in c-c is all imported from mozilla/ anyway (build.mk)
>
> Then, should we be able to remove the other references to "tier" in rules.mk? (and maybe config.mk??)
Probably
}
Flags: in-testsuite-
Reporter | ||
Updated•13 years ago
|
Whiteboard: [good first bug][lang=make]
Comment 1•12 years ago
|
||
Only comm-central refs are in calendar/ and suite/
Moving this to seamonkey
Product: MailNews Core → SeaMonkey
Comment 2•10 years ago
|
||
The build system has been revamped several times since this bug was opened. I don't think any of this applies any more.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → INVALID
Whiteboard: [good first bug][lang=make]
Reporter | ||
Comment 3•10 years ago
|
||
(In reply to Philip Chee from comment #2)
> The build system has been revamped several times since this bug was opened.
> I don't think any of this applies any more.
Not obvious to me: make code seems to be duplicated still and add_tier_dir() calls are in m-c only.
I haven't followed what happened for quite some time, yet I would like a bit of confirmation about the current status.
Thanks.
Flags: needinfo?(philip.chee)
Flags: needinfo?(bugspam.Callek)
Comment 4•10 years ago
|
||
I'm pretty sure tier's are being removed in the main build system now, I'll defer the proper answer to c#3 to jcranmer
Flags: needinfo?(philip.chee)
Flags: needinfo?(bugspam.Callek)
Flags: needinfo?(Pidgeot18)
Comment 5•10 years ago
|
||
Tiers as originally conceived are basically dead. The use of add_tier_dir in moz.build is basically an anachronism at this point AFAICT. The use of tiers in the makefiles is actually supposed to be in reference to export/compile/libs/tools, aside from rules that are probably dead.
For what it's worth, I prefer to keep diffs between comm-central and mozilla-central makefiles minimized as we move to eliminating the c-c build system, so I don't think there's anything valuable here.
Flags: needinfo?(Pidgeot18)
Reporter | ||
Comment 6•10 years ago
|
||
(In reply to Joshua Cranmer [:jcranmer] from comment #5)
> For what it's worth, I prefer to keep diffs between comm-central and
> mozilla-central makefiles minimized as we move to eliminating the c-c build
> system, so I don't think there's anything valuable here.
Thanks for the details. Agreed.
V.Invalid, as reporter.
Status: RESOLVED → VERIFIED
Summary: rules.mk: remove "tier" support code → rules.mk: remove "tier" support code (in SeaMonkey)
You need to log in
before you can comment on or make changes to this bug.
Description
•