Closed
Bug 873834
Opened 12 years ago
Closed 11 years ago
rules.mk: remove "tier" support code in calendar code
Categories
(Calendar :: Build Config, defect)
Calendar
Build Config
Tracking
(Not tracked)
RESOLVED
FIXED
2.6
People
(Reporter: mkmelin, Assigned: mschroeder)
References
()
Details
(Whiteboard: [good first bug][mentor=Fallen][lang=make])
Attachments
(1 file)
|
(deleted),
patch
|
Fallen
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #543271 +++
I noticed this while checking
http://hg.mozilla.org/mozilla-central/rev/0cb6d4bc7eae
(no bug): Add echo-tier-dirs target, to display tiers' directories. r=bsmedberg
Callek) told me:
{
>> The only reference to tiers is from mozilla/ and our use of tiers in c-c is all imported from mozilla/ anyway (build.mk)
>
> Then, should we be able to remove the other references to "tier" in rules.mk? (and maybe config.mk??)
Probably
}
Only ref left in calendar is http://mxr.mozilla.org/comm-central/source/calendar/providers/gdata/build.mk#25
|
||
Comment 1•12 years ago
|
||
I doubt the gdata provider will actually be built separately like it says in that file. I would be fine with removing the file altogether.
|
Reporter | |
Comment 2•12 years ago
|
||
Adding you as mentor, though i guess the steps are fairly clear:)
Whiteboard: [good first bug][lang=make] → [good first bug][mentor=Fallen][lang=make]
|
Assignee | |
Comment 3•11 years ago
|
||
|
|
||
Comment 4•11 years ago
|
||
Comment on attachment 764257 [details] [diff] [review]
Patch v1
Review of attachment 764257 [details] [diff] [review]:
-----------------------------------------------------------------
Keine Tiere mehr im Baum :-) r=philipp
Attachment #764257 -
Flags: review?(philipp) → review+
|
|
Assignee | |
Comment 5•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.6
You need to log in
before you can comment on or make changes to this bug.
Description
•