Closed
Bug 544773
Opened 15 years ago
Closed 12 years ago
[TSF] TSF related code should output logs on release build
Categories
(Core :: Widget: Win32, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla18
People
(Reporter: masayuki, Assigned: masayuki)
References
Details
(Keywords: inputmethod)
Attachments
(2 files, 5 obsolete files)
|
(deleted),
patch
|
jimm
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
jimm
:
review+
|
Details | Diff | Splinter Review |
TSF related code should output logs on release build because we cannot test all TIS in the world. The logs helps us for debugging. And all bug reporters can post the logs on release build.
# IMM32 code and new GTK2 IMModule code output the logs for same reason even if they are release build.
|
Assignee | |
Updated•15 years ago
|
Keywords: inputmethod
|
|
Assignee | |
Comment 1•12 years ago
|
||
jimm:
If you are busy, I'll update your patch too.
|
|
Assignee | |
Comment 2•12 years ago
|
||
Something has been broken.
Attachment #658787 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 3•12 years ago
|
||
Attachment #659199 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 4•12 years ago
|
||
Attachment #659205 -
Attachment is obsolete: true
Attachment #659457 -
Flags: review?(jmathies)
|
|
Assignee | |
Comment 5•12 years ago
|
||
Attachment #659458 -
Flags: review?(jmathies)
|
|
Assignee | |
Comment 6•12 years ago
|
||
Added some useful logs.
And do you know a good method for logging GUID in GetRIIDName()?
Attachment #659457 -
Attachment is obsolete: true
Attachment #659457 -
Flags: review?(jmathies)
Attachment #659462 -
Flags: review?(jmathies)
|
||
Comment 7•12 years ago
|
||
(In reply to Masayuki Nakano (:masayuki) (Mozilla Japan) from comment #6)
> Created attachment 659462 [details] [diff] [review]
> Patch part.1
>
> Added some useful logs.
>
> And do you know a good method for logging GUID in GetRIIDName()?
Just StringFromCLSID, for example:
OLECHAR* bstrGuid;
StringFromCLSID((const IID)*paFilterAttrs, &bstrGuid);
Log(L"RequestSupportedAttrs: clsid = %s", bstrGuid);
CoTaskMemFree(bstrGuid);
For a clsid name you have to manually dig through the registry.
|
|
Assignee | |
Comment 8•12 years ago
|
||
Thanks!
Attachment #659462 -
Attachment is obsolete: true
Attachment #659462 -
Flags: review?(jmathies)
Attachment #659489 -
Flags: review?(jmathies)
|
|
||
Comment 9•12 years ago
|
||
Comment on attachment 659489 [details] [diff] [review]
Patch part.1
nice.
Attachment #659489 -
Flags: review?(jmathies) → review+
|
|
||
Updated•12 years ago
|
Attachment #659458 -
Flags: review?(jmathies) → review+
|
|
Assignee | |
Comment 10•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/38311ad62c1d
https://hg.mozilla.org/integration/mozilla-inbound/rev/f082e741d78c
Target Milestone: --- → mozilla18
|
||
Comment 11•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/38311ad62c1d
https://hg.mozilla.org/mozilla-central/rev/f082e741d78c
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•