Closed Bug 554874 Opened 15 years ago Closed 15 years ago

[D2D] Menu, tabs and icons look messed up since Bug 546259 (Enable Aero Glass) landed 2d/dw

Categories

(Core :: Graphics, defect)

x86
Windows 7
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: Myzar74, Assigned: bas.schouten)

References

Details

(Keywords: regression, Whiteboard: 2d/dw Aero Glass)

Attachments

(3 files)

User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a4pre) Gecko/20100325 FireFox/3.6 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a4pre) Gecko/20100325 FireFox/3.6 Looks like the new glass patch doesn't play good with 2d & dw Reproducible: Always Steps to Reproduce: 1. Download latest trunk build 2. Turn on Direct2d and Directwrite 3. Actual Results: Menu, tabs and icons look messed up since this landed Bug 546259 2d/dw Pictures showing the problem http://img121.imageshack.us/img121/1306/uglye.jpg http://img109.imageshack.us/img109/344/ugly2.jpg Expected Results: Everything should look like with d2d/dw disabled
Blocks: 527707
Component: Theme → Graphics
Product: Firefox → Core
QA Contact: theme → thebes
Keywords: regression
Whiteboard: 2d/dw Aero Glass
Version: unspecified → Trunk
Confirmed. This happens as soon as glass is applied underneath anything painted with D2D. And it sure doesn't look pretty... There must be an issue with the D2D implementation here, as it is supposed to be better at transparency than GDI.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: Menu, tabs and icons look messed up since this landed Bug 546259 2d/dw → [D2D] Menu, tabs and icons look messed up since this landed Bug 546259 2d/dw
No issues with software-rendered DirectWrite (i945GM).
Toolbar icons stay selected when pressed. Visual glitches all over the place. Switching to a new W7 visual style will mess things up. d2d is enabled. Changing to a basic visual theme seems ok. Definitely a work in progress.
I get that broken rendering randomly but i was already getting it before this landed. That's probably another bug not related to aeroglass
This is what I'm seeing with D2D disabled. http://img176.imageshack.us/img176/8895/ffeffedaeroglass.png
I confirm this as well. The tabs also don't update; if you close a tab it will sort of stay there.. Like it doesn't refresh the gui.
This is caused by 3 known bugs, all are being worked on.
Assignee: nobody → bas.schouten
Status: NEW → ASSIGNED
Depends on: 555353, 555388
No longer depends on: 555388
Depends on: 555388
Blocks: 556537
Cannot reproduce. Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a5pre) Gecko/20100412 Minefield/3.7a5pre ATI Mobility Radeon HD 4530 (driver version 8.632.0.0
(In reply to comment #12) > Cannot reproduce. > Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a5pre) Gecko/20100412 > Minefield/3.7a5pre > ATI Mobility Radeon HD 4530 (driver version 8.632.0.0 You can't reproduce it because aero glass was turned off. This bug should probably should be resolved but it would most likely be reopened once aero glass is turned back on.
Blocks: 556196
No longer blocks: 556196
This is still an issue now that Areo glass has been turned back on with D2D/DW enabled.
The white halo effect surrounding the text in the titlebar, bookmarks in the bookmarks bar and menubar without D2D/DW enabled is also shown as pure white when D2D/DW is enabled.
(In reply to comment #10) > This is caused by 3 known bugs, all are being worked on. Bas, do you have bugs on file for these? I'm curious and would like to follow them so I can know when to turn D2D back on again.
(In reply to comment #16) > (In reply to comment #10) > > This is caused by 3 known bugs, all are being worked on. > > Bas, do you have bugs on file for these? I'm curious and would like to follow > them so I can know when to turn D2D back on again. Bug 555353 is one, there's one other problem which isn't hard to fix but I haven't put up a patch yet or filed a bug for it.
Summary: [D2D] Menu, tabs and icons look messed up since this landed Bug 546259 2d/dw → [D2D] Menu, tabs and icons look messed up since Bug 546259 (Enable Aero Glass) landed 2d/dw
I was able to still not drop D2D using a persona as a workaround but i'm still getting transparent tooltips on the bookmark sidebar and the same transparent menus on the tab bar, importance flags on bugzilla are also transparent. That's still the same bug ? btw this should gain a better priority and maybe be a blocker , we can't test D2D with an unusable browser
It seems like the toolbars' contents aren't redrawing very well at all. (I had already closed the addon manager's tab, my mouse is nowhere near the refresh button but it's still glowing, and all of the bookmarks look like I'm hovering over them.) Resizing the window itself seemed to fix everything (at least, until I closed another tab, hovered over a button, etc). Not sure if this is caused by Aero. Thoughts?
We'll for non developers I think its hard to tell until we have some of the other bug fixes landed on the trunk.
Depends on: 568495
I've been having the same problems as the original report, as well as in Comment 4. I have Googled my rains out but cannot figure out how to disable Aero Glass (in my opinion, the worst UI "enhancement" ever designed), but a few posts suggested that using the Stylish add-on would fix the visual corruptions from this bug, which it seems to do. I run Win7 x64, nVidia GeForce 9800GT, 8GB RAM.
I don't really remember, but I think this is new in a recent nightly. The separators in each of the menus seems to be missing with D2D enabled.
(In reply to comment #24) > I don't really remember, but I think this is new in a recent nightly. > > The separators in each of the menus seems to be missing with D2D enabled. I've had this since the early days of enabling d2d. The separators come and go for me.
Disabling Direct2d (use gfx.font_rendering.directwrite.enabled) OR disabling aero (by using a persona theme) are the only fixes right now
(In reply to comment #22) >I have Googled my rains out but cannot figure out how to disable > Aero Glass (in my opinion, the worst UI "enhancement" ever designed) Here is the fix! Use a persona theme For ur convenience : http://www.getpersonas.com/en-US/persona/53271
(In reply to comment #27) > (In reply to comment #22) > >I have Googled my rains out but cannot figure out how to disable > > Aero Glass (in my opinion, the worst UI "enhancement" ever designed) > > Here is the fix! Use a persona theme > > For ur convenience : http://www.getpersonas.com/en-US/persona/53271 Also avoid new Nvidia drivers and make sure you have plenty of RAM.
(In reply to comment #28) > (In reply to comment #27) > > (In reply to comment #22) > > >I have Googled my rains out but cannot figure out how to disable > > > Aero Glass (in my opinion, the worst UI "enhancement" ever designed) > > > > Here is the fix! Use a persona theme > > > > For ur convenience : http://www.getpersonas.com/en-US/persona/53271 > > Also avoid new Nvidia drivers and make sure you have plenty of RAM. New Nvidia drivers (the 257 beta drivers) are the best for d2d. As it prevents/fixes rendering issues https://bugzilla.mozilla.org/show_bug.cgi?id=558708
(In reply to comment #29) > (In reply to comment #28) > > (In reply to comment #27) > > > (In reply to comment #22) > > > >I have Googled my rains out but cannot figure out how to disable > > > > Aero Glass (in my opinion, the worst UI "enhancement" ever designed) > > > > > > Here is the fix! Use a persona theme > > > > > > For ur convenience : http://www.getpersonas.com/en-US/persona/53271 > > > > Also avoid new Nvidia drivers and make sure you have plenty of RAM. > > New Nvidia drivers (the 257 beta drivers) are the best for d2d. > As it prevents/fixes rendering issues > https://bugzilla.mozilla.org/show_bug.cgi?id=558708 Interesting, exactly the opposite experience here - rendering break more often, and menu rendering issues.
I was also trying the suggested beta driver from nvidia (I'm using an Geforce 8600 GTS here) and downgraded back to the old stable driver because I had more rendering issues with the new driver. More problems with the menus not drawing correctly.
Could we please keep comments in this bug relevant to code changes to actually fix it, and confine other discussion to this Mozillazine forum? http://forums.mozillazine.org/viewtopic.php?f=23&t=1775755 Thank you.
The underlying bugs have been resolved.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Looks like the main issues here are fixed, just the background is still black rather than transparent glass which is probably 555133 and 555950.
(In reply to comment #34) > Looks like the main issues here are fixed, just the background is still black > rather than transparent glass which is probably 555133 and 555950. Could you paste a screenshot of what you mean? Everything seems fine for me, but maybe I'm missing something.
Attached image Black Menu background (deleted) —
The menu issue looks like one of the attachments from bug 555950. The Download Mgr shows bug 556537.
I still have transparent tooltips on the bookmark sidebar, transparent menu on the url bar and transparent dropdown menus like on bugzilla http://img814.imageshack.us/img814/3334/caspermenu.jpg Looks like this is another bug and it's not the same issue fixed here
(In reply to comment #38) > I still have transparent tooltips on the bookmark sidebar, transparent menu on > the url bar and transparent dropdown menus like on bugzilla > > http://img814.imageshack.us/img814/3334/caspermenu.jpg > > Looks like this is another bug and it's not the same issue fixed here Is there a bug for this to vote on? i also have the same issue.
https://bugzilla.mozilla.org/show_bug.cgi?id=571019 I filed a bug. Hope it's not a dupe after my thorough search.
(In reply to comment #36) > Created an attachment (id=450170) [details] > Black Menu background > > The menu issue looks like one of the attachments from bug 555950. The Download > Mgr shows bug 556537. Filed 571068
Attached image Vertical lines, glowing menu (deleted) —
Firstly when I changed persona to default theme I got working glass and D2D. But, putting mouse over menu bar would cause old problem. (bright space around menu, bookmars ...) But when i restarted browser, it was fixed. Also seeing those lines posted in attachment. (look at the picture, glass changes color and menu names are glowing) Or this should be. (to produce it, click on start button to see change color and glowing, then click on taskbar - glowing is gone. Then click on browser color is back to normal)
(In reply to comment #42) > Created an attachment (id=450215) [details] > Vertical lines, glowing menu > > Firstly when I changed persona to default theme I got working glass and D2D. > But, putting mouse over menu bar would cause old problem. (bright space around > menu, bookmars ...) > But when i restarted browser, it was fixed. Also seeing those lines posted in > attachment. (look at the picture, glass changes color and menu names are > glowing) > Or this should be. (to produce it, click on start button to see change color > and glowing, then click on taskbar - glowing is gone. Then click on browser > color is back to normal) bug 571046 is vertical lines. The rest is inactive menu bar is shown when switching windows but not exclusive to D2D.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: