Closed
Bug 555388
Opened 15 years ago
Closed 15 years ago
Direct2D Clear should flush before copying
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: bas.schouten, Assigned: bas.schouten)
References
Details
Attachments
(2 files)
|
(deleted),
patch
|
jrmuizel
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
jrmuizel
:
review+
|
Details | Diff | Splinter Review |
We should flush before we copy render target content, for two reasons. First of all all clipping layers need to be popped when we call Clear. Second we need all pending operations to be flushed to the texture for the copying we do here.
|
Assignee | |
Comment 1•15 years ago
|
||
Attachment #435343 -
Flags: review?(jmuizelaar)
|
||
Comment 2•15 years ago
|
||
The state management seems a little haphazard here. _cairo_d2d_flush() pops the clipping layers and does an EndDraw() and so we need to add the new BeginDraw() and EndDraw() correct? Do we have or can we get a reftest that shows this bug?
No longer blocks: 554874
|
|
Assignee | |
Comment 3•15 years ago
|
||
Attachment #435717 -
Flags: review?(jmuizelaar)
|
|
||
Comment 4•15 years ago
|
||
Comment on attachment 435717 [details] [diff] [review]
Reftest clearing non rectangular clippaths
Looks good. We can land this right away.
Attachment #435717 -
Flags: review?(jmuizelaar) → review+
|
|
Assignee | |
Comment 5•15 years ago
|
||
(In reply to comment #4)
> (From update of attachment 435717 [details] [diff] [review])
> Looks good. We can land this right away.
Can we land the fix as well?
|
|
||
Comment 6•15 years ago
|
||
Comment on attachment 435343 [details] [diff] [review]
Fix Clear for special cases
Looks ok, but please add a comment above _cairo_d2d_clear_geometry about how it mucks with the Begin/EndDraw/clip state.
Attachment #435343 -
Flags: review?(jmuizelaar) → review+
|
|
Assignee | |
Comment 7•15 years ago
|
||
Pushed http://hg.mozilla.org/mozilla-central/rev/1c9357fc4c0e
Pushed http://hg.mozilla.org/mozilla-central/rev/4b40d5ef55a8
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•