Closed Bug 557569 Opened 15 years ago Closed 15 years ago

remove macosx64 and macosx64-debug from performing talos sendchange

Categories

(Release Engineering :: General, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: bear, Assigned: bear)

References

(Depends on 1 open bug)

Details

Attachments

(4 files, 2 obsolete files)

until the 32/64 bit data is reported as different items patch to remove talos master from sendchange list
Depends on: 557382
Assignee: nobody → bear
Attachment #437348 - Flags: review?(bhearsum)
Attachment #437348 - Flags: review?(bhearsum)
Attachment #437348 - Flags: review?(anodelman)
Attachment #437348 - Flags: review+
Comment on attachment 437348 [details] [diff] [review] override talos-master list for macosx64 and macosx64-debug This will get the 64-bit builds (debug and opt) only sending changes to the three masters specified. I don't know which ones we actually want them going to and which ones we don't, so I'm marking r?alice for that part.
Comment on attachment 437348 [details] [diff] [review] override talos-master list for macosx64 and macosx64-debug You need a change to misc.py I think to look for talos_masters in the platform dict.
Attachment #437348 - Flags: review?
Attachment #437348 - Flags: review?
You only need to send to talos-staging-master02, talos-staging-master is pretty much defunct.
Attachment #437348 - Attachment is obsolete: true
Attachment #437361 - Flags: review?(anodelman)
Attachment #437348 - Flags: review?(anodelman)
Comment on attachment 437361 [details] [diff] [review] override talos-master list for macosx64 and macosx64-debug List of masters looks correct to me. This will also let us play with it in stage until we are sure that everything is working.
Attachment #437361 - Flags: review?(anodelman) → review+
Attachment #437362 - Flags: review?(catlee)
Attachment #437361 - Flags: checked-in?
Comment on attachment 437362 [details] [diff] [review] changes to misc.py to enable overriding of talos_master talos_masters isn't being copied out of GLOBAL_VARS into the platform dictionaries. It gets copied into the per-branch dictionary though. So, we need to either put the talos_masters setting in the per-platform defaults, or copy all the GLOBAL_VARS into the platform dict. The first option sounds safest at this point. You might be able to do: 'talos_masters': GLOBAL_VARS['talos_masters'], for each of the platforms, except for the ones you want to override.
Attachment #437362 - Flags: review?(catlee) → review-
added setting of talos_master item to GLOBAL_VARS default for those which are not being explicitly overridden
Attachment #437362 - Attachment is obsolete: true
Attachment #437366 - Flags: review?(catlee)
Comment on attachment 437361 [details] [diff] [review] override talos-master list for macosx64 and macosx64-debug http://hg.mozilla.org/build/buildbot-configs/rev/122ecf5f62ae
Attachment #437361 - Flags: checked-in? → checked-in+
Attachment #437366 - Flags: review?(catlee) → review+
Comment on attachment 437366 [details] [diff] [review] config.py change to add the default GLOBAL_VARS talos_masters list Whoops. This, together with your previous patch will work.
Comment on attachment 437362 [details] [diff] [review] changes to misc.py to enable overriding of talos_master This should work with the new configs patch.
Attachment #437362 - Flags: review- → review+
Attachment #437366 - Attachment description: changes to misc.py to enable overriding of talos_master → config.py change to add the default GLOBAL_VARS talos_masters list
Comment on attachment 437366 [details] [diff] [review] config.py change to add the default GLOBAL_VARS talos_masters list http://hg.mozilla.org/build/buildbot-configs/rev/642d27213847
Attachment #437366 - Flags: checked-in+
Attachment #437361 - Attachment is obsolete: true
Attachment #437362 - Attachment is obsolete: false
Attachment #437362 - Flags: checked-in?
Attachment #437451 - Flags: review?(catlee)
Attachment #437451 - Flags: review?(catlee) → review+
Attachment #437451 - Flags: checked-in?
Comment on attachment 437451 [details] [diff] [review] changes to production config.py to work with misc.py changes http://hg.mozilla.org/build/buildbot-configs/rev/862dbf77a06e
Attachment #437451 - Flags: checked-in? → checked-in+
Attachment #437362 - Flags: checked-in? → checked-in+
Attachment #437885 - Flags: review?(anodelman)
Attachment #437885 - Flags: review?(anodelman) → review+
We actually no longer need this - we have snow leopard up and ready to test macosx64 bit builds.
(In reply to comment #18) > We actually no longer need this - we have snow leopard up and ready to test > macosx64 bit builds. So, this should be WONTFIX'd?
The reason for this bug was cleared up before the patches landed. Confirmed that the are not present in the source tree - marking as WONTFIX
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → WONTFIX
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: