Closed Bug 557789 Opened 15 years ago Closed 15 years ago

malloc error on OSx 10.4 in debug builds running regress/bug_515935.abc

Categories

(Tamarin Graveyard :: Garbage Collection (mmGC), defect, P2)

PowerPC
macOS
defect

Tracking

(Not tracked)

VERIFIED FIXED
flash10.1

People

(Reporter: brbaker, Assigned: treilly)

References

Details

Attachments

(1 file)

This only happens on 10.4 PPC and does not happen on 10.5 $AVM regress/bug_515935.abc Actual test is that exitcode 128 is returned. PASSED! Implementation limit exceeded: attempting to allocate too-large object error: out of memory avmshell_d_104_ppc(9473) malloc: *** Deallocation of a pointer not malloced: 0x2740e000; This could be a double free(), or free() called with the middle of an allocated block; Try setting environment variable MallocHelp to see tools to help debug This started happening with TR-ARGO rev 3900 http://asteam.macromedia.com/hg/tamarin-redux-argo/rev/3900 http://hg.mozilla.org/tamarin-redux/rev/4245
Flags: in-testsuite+
Flags: flashplayer-triage+
Flags: flashplayer-qrb?
Flags: flashplayer-injection+
What's happening is that we're aborting due to a too large allocation and leaking some large allocations which GCHeap isn't handling it properly.
Attached patch fixes 10.4 issue (deleted) — Splinter Review
10.4 doesn't use virtual memory so when Large objects are leaked they need to be handled separately in FreeAll. It could be argued that we shouldn't be using VM API's on 10.4 but the only reason we don't use them is that they don't support decommit/recommit and we don't do that with the Large object allocations.
Attachment #437548 - Flags: review?(lhansen)
Comment on attachment 437548 [details] [diff] [review] fixes 10.4 issue That assert looks aggressive since I had assumed that leaks could happen anywhere by code simply not freeing a large object, but you know best.
Attachment #437548 - Flags: review?(lhansen) → review+
The precedent set in GCHeap::DestroyInstance is that we assert on leaks unless we're aborting
Flags: flashplayer-qrb? → flashplayer-qrb+
Priority: -- → P2
Target Milestone: --- → flash10.1
Assignee: nobody → treilly
Status: NEW → ASSIGNED
tamarin-redux-argo: changeset: 3952:99b8651e2683 tamarin-redux: changeset: 4339:99b8651e2683
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Verified that the testcase is no longer failing on 10.4 in tr-argo 3952
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: