Closed Bug 560018 Opened 14 years ago Closed 14 years ago

{ get property funname() { } } not actually prohibited, likely due to a mis-rebase through parser changes

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9.3a5

People

(Reporter: Waldo, Assigned: Waldo)

References

()

Details

Attachments

(1 file)

Attached patch Patch and test (deleted) — Splinter Review
I really should have checked this bit more carefully before pushing the change that ostensibly removed support. It probably interfered with rebasing half a dozen times with all the C++ification and de-macroization that's been happening in SpiderMonkey lately.
Attachment #439682 - Flags: review?(lw)
Attachment #439682 - Flags: review?(lw) → review+
I was actually glad that it slipped away. Why do we have to lose this "feature" anyway? Naming functions is essential for debugging/profiling, and being a 1-line change, it doesn't seem to hurt code base.
Functions should have a debugName anyway, in my opinion, but this "feature" is about as ugly and nonsensical as it gets. We should get rid of it while we still can.
(In reply to comment #2) > Functions should have a debugName anyway, Yes, please file this. We should do it, JSC supports it and such a lightweight de-facto standard would be easy to standardize in Ecma TC39. http://wiki.ecmascript.org/doku.php?id=strawman:name_property_of_functions is the page to read and update as appropriate (it's about other aspects of "a function's name" but takes in debugName too). /be
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Depends on: 561638
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: