Closed
Bug 561638
Opened 14 years ago
Closed 14 years ago
Weave Error in Trunk Nightly (Status Bar Icon Missing)
Categories
(Cloud Services :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
1.3b2
People
(Reporter: murph.0912, Assigned: Mardak)
References
Details
(Whiteboard: [fixed-1.2.2] )
Attachments
(1 file)
(deleted),
patch
|
mconnor
:
review+
|
Details | Diff | Splinter Review |
Starting with today's Minefield Trunk Nightly, the Weave Status Bar icon is missing and it appears that Weave is not loading when the browser starts up. The following error is showing in the Console:
Error: missing ( before formal parameters
Source file: file:///C:/Documents%20and%20Settings/rmurphy/Application%20Data/Mozilla/Firefox/Profiles/(current_profile)/extensions/%7B340c2bbc-ce74-4362-90b5-7c26312808ef%7D/modules/service.js
Line: 129, Column: 15
Source code:
get password password() ID.get("WeaveID").password,
Trunk Build ID: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a5pre) Gecko/20100425 Minefield/3.7a5pre - Build ID: 20100425040736
Changeset: 2f01bfd52a75
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.3a5pre) Gecko/20100425 Minefield/3.7a5pre
I also get:
Error: gWeaveWin is undefined
Source File: chrome://browser/content/browser.xul
Line: 1
Error: missing ( before formal parameters
Source File: file:///home/user123/.mozilla/firefox/profilexyz/extensions/%7B340c2bbc-ce74-4362-90b5-7c26312808ef%7D/modules/service.js
Line: 129, Column: 15
Source Code:
get password password() ID.get("WeaveID").password,
Reporter | ||
Comment 2•14 years ago
|
||
(In reply to comment #0)
> Starting with today's Minefield Trunk Nightly, the Weave Status Bar icon is
> missing and it appears that Weave is not loading when the browser starts up.
> The following error is showing in the Console:
>
> Error: missing ( before formal parameters
> Source file:
> file:///C:/Documents%20and%20Settings/rmurphy/Application%20Data/Mozilla/Firefox/Profiles/(current_profile)/extensions/%7B340c2bbc-ce74-4362-90b5-7c26312808ef%7D/modules/service.js
> Line: 129, Column: 15
> Source code:
> get password password() ID.get("WeaveID").password,
>
>
> Trunk Build ID: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a5pre)
> Gecko/20100425 Minefield/3.7a5pre - Build ID: 20100425040736
>
> Changeset: 2f01bfd52a75
FYI: This error is triggered when opening the Tools > Options regardless of whether or not the Weave tab is the active tab.
Comment 3•14 years ago
|
||
So the same weave build, on the previous day's nightly, works fine?
Reporter | ||
Comment 4•14 years ago
|
||
For me, it was.
Reporter | ||
Comment 5•14 years ago
|
||
Sorry, I forgot to mention the Weave version. It is 1.2.1.
Comment 6•14 years ago
|
||
Can you install the previous nightly build to verify that's actually the case? Also, can you try running 1.3b1?
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.3a5pre) Gecko/20100425 Minefield/3.7a5pre
For me, Weave definitely worked in the 20100424 nightly but not in today's. Weave 1.2.1 (same as yesterday).
From:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2010-04-24-03-mozilla-central/firefox-3.7a5pre.en-US.linux-i686.txt
To:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2010-04-25-03-mozilla-central/firefox-3.7a5pre.en-US.linux-i686.txt
As a pushlog: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=d542ee95ef22&tochange=2f01bfd52a75
(Sidenote, where is the page to generate that? I just copied the URL from another bug and replaced the changesets...)
Verified Weave works in 4/24 nightly, breaks in 4/25 on OS X 10.5.8 PPC
Broken Weave isn't in the status bar; selecting it from Tools menu brings up weird 3 button popup for Signin Sync buttons do nothing.
Comment 10•14 years ago
|
||
Please see Bug 561646 - get Operator fails if the (optional) name of the function is specified
Assignee | ||
Comment 11•14 years ago
|
||
Yeah, waldo blogged about get/setters changing due to an oddity in spidermonkey in how it parses out function names. This should be fixed by just removing the old explicit name.
Assignee | ||
Comment 12•14 years ago
|
||
Comment 14•14 years ago
|
||
Same here with
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a5pre) Gecko/20100425 Minefield/3.7a5pre (.NET CLR 3.5.30729)
And
weave-1.3b1-dev.xpi
The icon is not in the status bar.
Is not sync-ing.
It show strange icons when I try to see the Options from the Add-Ons.
Doesn't work the Weave tab in Preferences.
Updated•14 years ago
|
Attachment #441368 -
Flags: review?(mconnor) → review+
Assignee | ||
Comment 15•14 years ago
|
||
http://hg.mozilla.org/labs/weave/rev/078ef559662e
Remove the extra name from get/set declarations now that Spidermonkey doesn't want them.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Flags: blocking-weave1.3+
Resolution: --- → FIXED
Target Milestone: --- → 1.3
Updated•14 years ago
|
Target Milestone: 1.3 → 1.3b2
Assignee | ||
Updated•14 years ago
|
Whiteboard: [fixed-1.2.2]
Reporter | ||
Comment 16•14 years ago
|
||
Thanks, 1.2.2 appears to be working fine in both Minefield/Trunk and Fx 3.6.x.
You need to log in
before you can comment on or make changes to this bug.
Description
•