Closed
Bug 56139
Opened 24 years ago
Closed 24 years ago
Composer should not offer to set the height of tables
Categories
(Core :: DOM: Editor, defect, P3)
Core
DOM: Editor
Tracking
()
VERIFIED
FIXED
mozilla0.9
People
(Reporter: karl, Assigned: Brade)
References
Details
(Whiteboard: patch attached)
Attachments
(4 files)
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review |
Steps to reproduce:
1. Open Composer.
2. Table | Insert Table.
3. See 'Height' input box.
Since the 'height' attribute actually *doesn't* exist in HTML (neither in
Strict nor in Transitional)
<URL:http://www.w3.org/TR/html401/struct/tables.html#edef-TABLE>, Mozilla
should *not* offer this option when inserting tables (Mozilla is supposed to
generate only valid HTML).
You *can* specify the height using the CSS 'height' property, but percentage
height is not the height of the window, but the height of the table's
containing block.
Assignee | ||
Updated•24 years ago
|
Target Milestone: --- → Future
Reporter | ||
Comment 1•24 years ago
|
||
Future? It's pretty easy to fix this -- just some XUL and (JS) editing.
Actually, I think I can fix it myself. If I attach modified XUL and JS files,
would they be checked in?
Reporter | ||
Comment 2•24 years ago
|
||
Future? It's pretty easy to fix this -- just some XUL and (JS) editing.
Actually, I think I can fix it myself. If I attach modified XUL and JS files,
would they be checked in?
Assignee | ||
Comment 3•24 years ago
|
||
Karl Ove Hufthammer--if you attach fixes, I can probably take a look at the
fixes and get them checked into the mozilla trunk.
Assignee | ||
Comment 4•24 years ago
|
||
I'll take this bug
Karl--let me know if you have some fixes so I don't redo your work!
Assignee: beppe → brade
Target Milestone: Future → mozilla0.9
Assignee | ||
Comment 5•24 years ago
|
||
note: this affects table properties dialog in addition to insert table dialog.
Reporter | ||
Comment 6•24 years ago
|
||
> Karl--let me know if you have some fixes so I don't redo your work!
I haven't (I've tried in an earlier build, and it seemed to work, but I've now
deleted it). Anyway, it's just removing some lines from a couple of XUL and JS
files.
Assignee | ||
Updated•24 years ago
|
Status: NEW → ASSIGNED
Whiteboard: fix in hand
Assignee | ||
Comment 7•24 years ago
|
||
Assignee | ||
Comment 8•24 years ago
|
||
Assignee | ||
Comment 9•24 years ago
|
||
note: the attached patches also address bug #57300
Whiteboard: fix in hand → patches attached
Assignee | ||
Comment 10•24 years ago
|
||
about to attach a new patch to replace the patch dated 10/27/00 06:39; note:
you'll still need the patch for 10/27/00 06:38 for removing the strings.
Assignee | ||
Comment 11•24 years ago
|
||
Assignee | ||
Comment 12•24 years ago
|
||
Comment 14•24 years ago
|
||
Comment 15•24 years ago
|
||
r=cmanske
Assignee | ||
Comment 16•24 years ago
|
||
This is now fixed (until css support for table height is completed); followup
bugs probably belong in one of these: #59991, #59992, #59993
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•