Closed Bug 562969 Opened 15 years ago Closed 14 years ago

enable crash reporting in Maemo release builds

Categories

(Release Engineering :: General, defect, P3)

ARM
Maemo
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ted, Assigned: mfinkle)

References

Details

(Whiteboard: [mobile] [fennec-l10n])

Attachments

(2 files)

+++ This bug was initially created as a clone of Bug #562968 +++ We just need to add export MOZILLA_OFFICIAL=1 to the mozconfigs. We need to do fix the branding issue first, though.
Priority: -- → P3
Whiteboard: [mobile]
Attached patch branding patch (deleted) — Splinter Review
This patch adds the crashreport-override.ini to fennec and overrides a few strings per Madhava's suggestions. We force the application name of "Firefox" regardless of official or nightly build.
Attachment #443744 - Flags: review?(ted.mielczarek)
Whiteboard: [mobile] → [mobile] [fennec-l10n]
Attachment #443744 - Flags: review?(l10n)
Comment on attachment 443744 [details] [diff] [review] branding patch r=me with a nit, in +# LOCALIZATION NOTE (CrashReporterErrorText): %s is replaced with another string containing detailed information. +CrashReporterProductErrorText2=Firefox has crashed. Unfortunately the crash reporter is unable to submit a crash report.\n\nDetails: %s the key name in the note doesn't match the entry. Didn't check if the foo2 entries are right, I guess there's historic reasons in the overwritten file?
Attachment #443744 - Flags: review?(l10n) → review+
Attachment #443744 - Flags: review?(ted.mielczarek) → review+
Guess we'll drop the branding dep then. Still need symbols to turn this on, and we should still do the nightlies first.
Depends on: 562968
No longer depends on: 416680
Depends on: 557114
No longer depends on: 562968
pushed m-b: http://hg.mozilla.org/mobile-browser/rev/3341ec53a58c Not pushing to m-1.1 until we get crashreporter functional on nightlies. We should still be able to start the l10n process on the strings. Also, not marking FIXED until we get "export MOZILLA_OFFICIAL=1" in the nightly mozconfigs.
I just noticed that "export MOZILLA_OFFICIAL=1" is already in the nightly mozconfigs!
This bug shouldn't be FIXED until we get it in the release mozconfigs.
Strings are ready for l10n to begin
Should the release mozconfig look like the current nightly, but with official branding? Currently that would mean adding --enable-debug-symbols, export MOZILLA_OFFICIAL=1, and keeping --disable-ipc.
Is the release happening off of a 1.9.2 branch? If so we'll need to tweak it a bit since --enable-debug-symbols didn't land there. We'll need instead: export CFLAGS="-gdwarf-2" export CXXFLAGS="-gdwarf-2" export MOZ_DEBUG_SYMBOLS=1 export MOZILLA_OFFICIAL=1
Attached patch mozconfig for 1.9.2 releases (deleted) — Splinter Review
Attachment #444199 - Flags: review?(ted.mielczarek)
Comment on attachment 444199 [details] [diff] [review] mozconfig for 1.9.2 releases I've got a larger patch with a bunch of mozconfig changes -- removing r? to avoid dups + merge conflicts :)
Attachment #444199 - Flags: review?(ted.mielczarek)
Looks like this is fixed.
Assignee: nobody → mark.finkle
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: