We need YASM installed on the x86_64 MacOS Mozilla build machines so that we can build VP8's optimized assembly on that platform. Can we have YASM installed on the build machines please? The same version of YASM which was installed on the Linux build machines (1.0.1.2326) works on Mac x86_64. Thanks!

We discussed this on IRC, and decided that we may as well install YASM on the Mac x86 machines as well as the x86_64 machines, so we're using the same assembler on all platforms except Windows.

This blocks bug 566247, which is blocking the next 1.9.3 alpha 5... So if we can get this done sooner rather than later that would be much appreciated!

Do we need to have a 64bit and 32bit build of yasm or is a single build able to target both 32bit and 64bit

(In reply to comment #3) > Do we need to have a 64bit and 32bit build of yasm or is a single build able to > target both 32bit and 64bit and also, what about PPC?

Pushing to jhford, as he did the linux one recently, and has the right headspace. Raised priority as beltzner said this is needed for 1.9.3a5.

A 32bit version of YASM can produce both x86 and x86_64 assembly, so no need for different versions on x86 and x86_64. Don't worry about PPC, we're using the slower fallback C code in libvpx on PPC.

(In reply to comment #6) > A 32bit version of YASM can produce both x86 and x86_64 assembly, so no need > for different versions on x86 and x86_64. > > Don't worry about PPC, we're using the slower fallback C code in libvpx on PPC. Ok, I will build yasm 1.0.1 32bit on a leopard machine.

yasm built on Darwin moz2-darwin9-slave01.build.mozilla.org 9.2.0 Darwin Kernel Version 9.2.0: Tue Feb 5 16:13:22 PST 2008; root:xnu-1228.3.13~1/RELEASE_I386 i386 wget http://www.tortall.net/projects/yasm/releases/yasm-1.0.1.tar.gz tar zxf yasm-1.0.1.tar.gz cd yasm-1.0.1 ./configure make -j4 make install DESTDIR=yasm-root on my laptop rsync -av cltbld@moz2-darwin9-slave01.build.mozilla.org:yasm-1.0.1/yasm-root . ./puppet-manifests/create-dmg.sh yasm-root/usr yasm-1.0.1 yasm / I have installed this package on my local machine and it is installed properly $ yasm --version yasm 1.0.1.2326 Compiled on Jun 2 2010. Copyright (c) 2001-2010 Peter Johnson and other Yasm developers. Run yasm --license for licensing overview and summary. $ file `which yasm` /usr/local/bin/yasm: Mach-O executable i386

[root@staging-puppet manifests]# ./test-manifests.sh Testing site-production.pp...OK Testing site-staging.pp...OK This patch has not been tested to actually deploy properly yet.

Comment on attachment 448860 [details] [diff] [review] puppet manifest changes This worked in testing moz2-darwin9-slave08:~ cltbld$ yasm --version yasm 1.0.1.2326 Compiled on Jun 2 2010. Copyright (c) 2001-2010 Peter Johnson and other Yasm developers. Run yasm --license for licensing overview and summary. moz2-darwin9-slave08:~ cltbld$ file `which yasm` /usr/local/bin/yasm: Mach-O executable i386 moz2-darwin9-slave08:~ cltbld$

Comment on attachment 448860 [details] [diff] [review] puppet manifest changes jhford tells me that this deployed fine on the darwin9 slaves too. looks good to me.

Comment on attachment 448860 [details] [diff] [review] puppet manifest changes http://hg.mozilla.org/build/puppet-manifests/rev/63b506c41412

spot checked some slaves (bm-xserve06, moz2-darwin9-slave06, moz2-darwin10-slave06) and all have yasm installed.