Closed
Bug 568925
Opened 14 years ago
Closed 14 years ago
[e10s] remote History Set Title for URI
Categories
(Core :: IPC, defect)
Tracking
()
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
fennec | 2.0a1+ | --- |
People
(Reporter: dougt, Assigned: dougt)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
dougt
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•14 years ago
|
||
Assignee: nobody → dougt
Attachment #448069 -
Flags: review?(sdwilsh)
Assignee | ||
Updated•14 years ago
|
Attachment #448069 -
Flags: review?(sdwilsh) → review?(jones.chris.g)
Comment on attachment 448069 [details] [diff] [review] patch v.1 >diff --git a/toolkit/components/places/src/History.cpp b/toolkit/components/places/src/History.cpp >--- a/toolkit/components/places/src/History.cpp >+++ b/toolkit/components/places/src/History.cpp >@@ -1162,18 +1162,28 @@ History::UnregisterVisitedCallback(nsIUR > > return NS_OK; > } > > NS_IMETHODIMP > History::SetURITitle(nsIURI* aURI, const nsString& aTitle) > { > NS_PRECONDITION(aURI, "Must pass a non-null URI!"); >+#ifdef MOZ_IPC >+ if (XRE_GetProcessType() == GeckoProcessType_Content) { >+ mozilla::dom::ContentProcessChild * cpc = Inconsistent pointer formatting (|Foo*| above). >+ mozilla::dom::ContentProcessChild::GetSingleton(); >+ NS_ASSERTION(cpc, "Content Protocol is NULL!"); >+ (void) cpc->SendSetURITitle(IPC::URI(aURI), aTitle); >+ return NS_OK; >+ } >+#endif /* MOZ_IPC */ > > nsNavHistory* history = nsNavHistory::GetHistoryService(); >+ Accidental newline?
Attachment #448069 -
Flags: review?(jones.chris.g) → review+
Assignee | ||
Comment 3•14 years ago
|
||
http://hg.mozilla.org/projects/electrolysis/rev/87122ab4c9b2
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 4•14 years ago
|
||
This was backed out a few days ago because the required places patches were backed out.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 5•14 years ago
|
||
just the patch Doug pushed to tryserver, that applies.
Attachment #448069 -
Attachment is obsolete: true
Updated•14 years ago
|
tracking-fennec: --- → 2.0+
Updated•14 years ago
|
tracking-fennec: 2.0+ → 2.0a1+
Comment 6•14 years ago
|
||
Could we add the relevant places patches as dependencies please? I'm having trouble figuring out what all needs to patched in what order.
OS: Linux → Windows CE
Assignee | ||
Comment 7•14 years ago
|
||
Comment on attachment 457429 [details] [diff] [review] patch v1.1 moving review forward.
Attachment #457429 -
Flags: review+
Assignee | ||
Comment 8•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/2900644a71c6
Status: REOPENED → RESOLVED
Closed: 14 years ago → 14 years ago
Resolution: --- → FIXED
Comment 9•14 years ago
|
||
Comment on attachment 457429 [details] [diff] [review] patch v1.1 >@@ -1259,6 +1259,16 @@ History::SetURITitle(nsIURI* aURI, const nsAString& aTitle) > return NS_OK; > } > >+#ifdef MOZ_IPC >+ if (XRE_GetProcessType() == GeckoProcessType_Content) { >+ mozilla::dom::ContentProcessChild* cpc = >+ mozilla::dom::ContentProcessChild::GetSingleton(); >+ NS_ASSERTION(cpc, "Content Protocol is NULL!"); >+ (void)cpc->SendSetURITitle(IPC::URI(aURI), nsDependentString(aTitle)); aTitle isn't guaranteed to be null-terminated. Did you mean PromiseFlatString?
Assignee | ||
Comment 10•14 years ago
|
||
no please file a new bug, and lets track it there. Thanks for noticing this issue!
You need to log in
before you can comment on or make changes to this bug.
Description
•