Closed
Bug 624742
Opened 14 years ago
Closed 13 years ago
Places shouldn't use nsDependentString to convert an nsAString to an nsString
Categories
(Core :: IPC, defect)
Core
IPC
Tracking
()
RESOLVED
FIXED
mozilla8
People
(Reporter: neil, Assigned: edgarf2002)
References
()
Details
(Whiteboard: [good first bug][mentor=jdm][inbound])
Attachments
(1 file)
|
(deleted),
patch
|
mak
:
review+
|
Details | Diff | Splinter Review |
Just use nsString, or maybe PromiseFlatString.
|
||
Updated•13 years ago
|
Whiteboard: [good first bug] → [good first bug][mentor=jdm]
|
Assignee | |
Comment 2•13 years ago
|
||
I'm interested in taking this up and I think I made the correct change in History.cpp. How do I proceed?
|
|
||
Comment 3•13 years ago
|
||
You'll want to follow the directions at https://developer.mozilla.org/en/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3f for generating the patch, then attach it here via the "Add an attachment link".
|
|
Assignee | |
Comment 4•13 years ago
|
||
|
|
||
Updated•13 years ago
|
Attachment #550763 -
Flags: review?(mak77)
|
||
Comment 5•13 years ago
|
||
Comment on attachment 550763 [details] [diff] [review]
Changed nsDependentString call to nsString
Review of attachment 550763 [details] [diff] [review]:
-----------------------------------------------------------------
Thank you, and congrats for your fist patch!
you may add a checkin-needed keyword to this bug to have someone push your patch to the repository
Attachment #550763 -
Flags: review?(mak77) → review+
|
|
Assignee | |
Comment 6•13 years ago
|
||
Thanks!!
|
Reporter | |
Updated•13 years ago
|
Assignee: nobody → edgarf2002
Keywords: checkin-needed
|
|
||
Comment 7•13 years ago
|
||
Keywords: checkin-needed
Whiteboard: [good first bug][mentor=jdm] → [good first bug][mentor=jdm][inbound]
|
|
||
Comment 8•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
You need to log in
before you can comment on or make changes to this bug.
Description
•