Closed Bug 570902 Opened 14 years ago Closed 14 years ago

Remove ifdefs relating to MOZILLA_1_9_2 from Thunderbird

Categories

(Thunderbird :: Build Config, defect)

Product:
Thunderbird
Component:
Build Config
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 3.3a1

People

(Reporter: Callek, Assigned: Callek)

References

Details

Attachments

(3 files)

remove storage-backport
(deleted), text/plain
asuth
: review+
standard8
: superreview+
Details
kill the ifdef
(deleted), patch
standard8
: review+
standard8
: superreview+
Details | Diff | Splinter Review
Kill the ifdefs in nsMessengerOSXIntegration
(deleted), patch
m_kato
: review+
Bienvenu
: superreview+
Details | Diff | Splinter Review
Mark told me on IRC we are ready for this for the rest of c-c.
Attached file remove storage-backport (deleted) —
The upcoming patch obsoletes storage-backport. Instead if show a patch that removes it all, I'll just attach the hg addremove output from its MQ changeset.
Attachment #450049 - Flags: superreview?(bugzilla)
Attachment #450049 - Flags: review?(bugmail)
I'm not sure what we are meant to do with: http://mxr.mozilla.org/comm-central/source/mailnews/base/src/nsMessengerOSXIntegration.mm So would appreciate someone else taking over that file work.
Attached patch kill the ifdef (deleted) — — Splinter Review
Attachment #450060 - Flags: review?(bugzilla)
Comment on attachment 450049 [details] remove storage-backport This seems right and the changes in the patch seem right too. (Per http://hg.mozilla.org/comm-central/rev/4be99c0f6036 I only touched 2 files outside of storage-backport, and your patch removes those bits again.)
Attachment #450049 - Flags: review?(bugmail) → review+
Attachment #450049 - Flags: superreview?(bugzilla) → superreview+
Attachment #450060 - Flags: review?(bugzilla) → review+
This seems to be the right way to get rid of the extra code in nsMessengerOSXIntegration. Requesting review from Makoto as he put in most of the ifdefs in the first place ;-)
Attachment #450086 - Flags: superreview?(bienvenu)
Attachment #450086 - Flags: review?(m_kato)
Attachment #450086 - Flags: review?(m_kato) → review+
Attachment #450086 - Flags: superreview?(bienvenu) → superreview+
Attachment #450060 - Flags: superreview+
Both patches checked in: http://hg.mozilla.org/comm-central/rev/2b23b224f246 http://hg.mozilla.org/comm-central/rev/7d85c2f48e77
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.2a1
Landed the storage-backport removal http://hg.mozilla.org/comm-central/rev/115997fdba57 though I botched the commit message on that one.
Depends on: 571644
No longer depends on: 571644
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: