User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US) AppleWebKit/533.4 (KHTML, like Gecko) Chrome/5.0.375.70 Safari/533.4 Build Identifier: ver 3.4.6 (ru: 3.4.3) I received a letter from the "Requests". There is no possibility to filter the header "X-Bugzilla-Product" Reproducible: Always Actual Results: No header "X-Bugzilla-Product" in the letter "Requests" Expected Results: is the header of "X-Bugzilla-Product" in the letter "Requests"

Dupe of bug 390586?

I do not think that it is Duplicate.

(In reply to comment #0) > I received a letter from the "Requests". What is that?? A flag mail?

(In reply to comment #3) > What is that?? A flag mail? X-Bugzilla-Type: request

Help solve the problem? Because of this problem, I can not sort the letters ("Requests") by the field Product.

Why "UNCONFIRMED"?

Let me translate again :-) request/email.txt.tmpl does not include X-Bugzilla-Product: header. Also, product is not passed in template call. Yes one can dig product out of bug object anyway, but it is rather tricky for average Bugzilla customizer. source: http://forum.mozilla-russia.org/viewtopic.php?id=44812 AFAICT it is not a duplicate of bug 390586 because this bug affects any recipient, not just Cc:

(In reply to comment #8) > Let me translate again :-) Good :-)

Comment on attachment 686520 [details] [diff] [review] patch to change header Review of attachment 686520 [details] [diff] [review]: ----------------------------------------------------------------- I am reluctant to r+ this one as it will not stop with Product. If you add that, people will want more of the bug attributes added until we have the same amount as normal bugmail. Flag emails were meant to be simple notifications to the requestee that they need to address the requested flag. And not meant to be a normal bug email. Those are sent separately which do have all of the proper headers. That being said, I can see they need to be able to filter the flag emails on the client side so I am open to discussing further. LpSolit, what do you think? Should we add the product header and additionally component and version maybe? dkl

(In reply to David Lawrence [:dkl] from comment #11) > LpSolit, what do you think? Should we add the product header and > additionally component and version maybe? If we follow this path, we are going to duplicate all headers from email/bugmail-header.txt.tmpl, which is something we agree we don't want to see happening. In that case, it would make more sense to share the code with email/bugmail-header.txt.tmpl than to duplicate everything. So I agree with you to not approve this patch.

Comment on attachment 686520 [details] [diff] [review] patch to change header r- due to the two previous comments.

Comment on attachment 687023 [details] [diff] [review] Updated patch to address last two comments Review of attachment 687023 [details] [diff] [review]: ----------------------------------------------------------------- I think it would better if we named the new template 'header-common.txt.html' for consistency with other template naming. Attach new patch with changed filename then r+ since everything else looks fine and worked as expected for me. ::: template/en/default/email/bug-header.txt.tmpl @@ +4,5 @@ > + # > + # This Source Code Form is "Incompatible With Secondary Licenses", as > + # defined by the Mozilla Public License, v. 2.0. > + #%] > + Remove extra whitespace here

(In reply to David Lawrence [:dkl] from comment #15) > I think it would better if we named the new template > 'header-common.txt.html' for consistency with other template naming. I assume you meant .txt.tmpl, which I have done. > Remove extra whitespace here Done

Comment on attachment 687251 [details] [diff] [review] Updated patch to address last comment Review of attachment 687251 [details] [diff] [review]: ----------------------------------------------------------------- Looks fine and works as expected. r=dkl

Thanks for the patch! Committing to: bzr+ssh://dlawrence%40mozilla.com@bzr.mozilla.org/bugzilla/trunk modified template/en/default/email/bugmail-header.txt.tmpl modified template/en/default/email/flagmail.txt.tmpl added template/en/default/email/header-common.txt.tmpl Committed revision 8509.

(In reply to Andrey from comment #2) > I do not think that it is Duplicate. It is definitely a duplicate.

Added to relnotes for 5.0rc1.