Using NT color preferences that are perfectly legible with Communicator 4.75 I end up with black on black on M18 at various places in the UI (menus, checkboxes, radio buttons). (Actually, this is an improvement over M17, where the URL entry box came out black on black).

Adding "Win" to subject, sending to Joe

duplicate of bug 57426?

The bugreport as such is a duplicate of 57426. There are several attachments there too, and even more references to attachments. I dont know why the attachments have been scattered around in two different bugs when the bug is one and the same. Perhaps the attachments are identical as well. The attachment in 57426 are: http://bugzilla.mozilla.org/showattachment.cgi?attach_id=17625 References added in comment by jsteenhagen@novagate.com are: http://bugzilla.mozilla.org/showattachment.cgi?attach_id=17626 http://bugzilla.mozilla.org/showattachment.cgi?attach_id=17627 jsteenhagen in addition commented that the bug may be related to 48443. Marking bug 57426 dup of this, since this one is assigned to hewitt, and all attachments now are known here.

*** Bug 57426 has been marked as a duplicate of this bug. ***

The text accompanying attachments is: 17625: registry subtree with color scheme for reproducing the bug 17626: What menu looks like in M18 17627: What menu looks like in 4.75

Themes Triage Team nsbeta1+ (changed summary as well)

*** Bug 46911 has been marked as a duplicate of this bug. ***

*** Bug 48067 has been marked as a duplicate of this bug. ***

*** Bug 53301 has been marked as a duplicate of this bug. ***

*** Bug 56507 has been marked as a duplicate of this bug. ***

*** Bug 48443 has been marked as a duplicate of this bug. ***

*** Bug 48920 has been marked as a duplicate of this bug. ***

*** Bug 53432 has been marked as a duplicate of this bug. ***

*** Bug 53558 has been marked as a duplicate of this bug. ***

*** Bug 55168 has been marked as a duplicate of this bug. ***

*** Bug 66131 has been marked as a duplicate of this bug. ***

*** Bug 48921 has been marked as a duplicate of this bug. ***

Changed subject to reflect dupes under Linux with gtk themes.

Just for the record, Diego, there is no "Linux Classic" theme. Linux uses the Windows classic theme.

as always whether a specific theme decides to use such support is up to it.

I've been working on this bug, and bug 51346 (system fonts) for the last day or so, and I think I've finally got it nailed. I've tested extensively on Windows and Linux and it seems to look correct now under all system color combinations. The patch to fix this is big and hairy. As I've been fixing this I've also been touching up various other things in some css files, so my patch may have some irrelevant things in it. For those of you who want to review this before I check it in, would you prefer I post the whole classic.jar so you can easily test it, or just post the whole mess of patches?

Mind doing both? If it's too much trouble, the patches would be easier to review...

one long cvs diff -u from the parent of where you change and a classic.jar would be nice.

(N.B. this is not a set of diffs from hewitt@netscape.com as you might casually assume if you were just skimming through here. It's a set of diffs from the j-random user who initially filed the bug.) after receiving a flurry of marked duplicate messages recently, I took a look at comments on the related bugs and came up with a set of classic.jar diffs that mostly works for me. A few comments: I didn't include check-check.gif and check-radio.gif 'cause the ones I created were specific to my color scheme (it wasn't quickly apparent to me how to make generic ones) the window you get from selecting _V_iew S_o_urce still has black text on a black background (the workaround is to type ctrl/A). Where to find this in CSSland was not quickly apparent to me. there are still a few dozen places where white, black, #000000 and #ffffff are hard-wired. I didn't check for other (inappropriately hardwired?) colors.

*** Bug 66094 has been marked as a duplicate of this bug. ***

The following patch covers a large number of css files in the classic skin. It also includes several related fixes for other bugs, namely: 51346 (system fonts), 46961 (disabled buttons), 45060 (addressing widget lines), 66210 (treecell headers), 58951 (menuitem alignment), 52704/52703 (disabled menulists), 52036 (go/search buttons), 52906/50190 (sidebar tabs), 64364 (personal toolbar), 50439 (bookmark icons), 65444 (css error) I should note that one other change I've made here, which affects a lot of files, but is purely cosmetic, is to rename all of the UI Color names to be upper case, as is recommended in the CSS2 spec and looks nicer to my eyes. The changes here affect only the windows/linux classic theme, not mac.

I'd love to get a review on this patch asap, as it will fix a boatload of bugs in the classic skin. Help!

Can we have patched classic.jar also? For me it'll be more convinient to test it...

There are some promblems with classic.jar, not all patches included, for example all patches from menu.css is absent, not sure about others...

r=hyatt

fixed. Some people have reported some color weirdness on Linux and Windows after my checkin. Please file separate bugs specific to those issues, thanks.

Marking verified on windows and linux(2001-02-02-10-Mtrunk)

(this is the original reporter of the bug) As I commented semi-recently in http://bugzilla.mozilla.org/show_bug.cgi?id=71466#c5 and more recently in http://bugzilla.mozilla.org/show_bug.cgi?id=69434#c22 radio buttons and checkboxes have started appearing in foreground color for me in Phoenix 0.5 and Mozilla 1.3a (note that when this bug was marked VERIFIED FIXED, it HAD fixed most of the GUI elements that were having problems - however, the problems with checkboxes and radio boxes had a different source, and were re-opened in 69434.)