The Firefox button should be enabled by default on Windows Vista and Windows 7. The menubar should remain the default option on Windows XP.

Disabling it for aero basic would also be great if we can do it.

(In reply to comment #1) > Disabling it for aero basic would also be great if we can do it. What will it look like if we don't?

this does not handle aero basic in any special way

(In reply to comment #3) > Created an attachment (id=453847) [details] > patch > > this does not handle aero basic in any special way Another oddity I noticed, if you enable the the menu bar, the fx button goes away. W/ chrome margins on, the menu bar is all the way up on the titlebar. We should probably disable chromemargins if the fx button is hidden. I'll post some screen shots.

Does disabling chromemargins mean removing the chromemargin attribute?

(In reply to comment #5) > Does disabling chromemargins mean removing the chromemargin attribute? Yes, that should do it.

Jim, could you please try this?

(In reply to comment #8) > Created an attachment (id=453860) [details] > patch > > Jim, could you please try this? The menu bar still shows up in the titlebar if it's enabled via the menu option. (the fx button goes away) Need to test on xp still. I hardcoded chromemargins off in widget for aero basic desktops so we don't have to worry about that.

If you turn the menu back on and the Firefox button off then it should probably just re-enable the titlebar.

(In reply to comment #10) > If you turn the menu back on and the Firefox button off then it should probably > just re-enable the titlebar. Probably, but if that's really tough, I don't think I would consider it a beta1 blocker.

(In reply to comment #9) > The menu bar still shows up in the titlebar if it's enabled via the menu > option. (the fx button goes away) Could this be a problem with nsXULElement::UnsetAttr in attachment 453280 [details] [diff] [review]? Looks like aName wants to be nsGkAtoms::hidechrome and nsGkAtoms::chromemargin at the same time...

(In reply to comment #12) > (In reply to comment #9) > > The menu bar still shows up in the titlebar if it's enabled via the menu > > option. (the fx button goes away) > > Could this be a problem with nsXULElement::UnsetAttr in attachment 453280 [details] [diff] [review]? > Looks like aName wants to be nsGkAtoms::hidechrome and nsGkAtoms::chromemargin > at the same time... That's definitely not going to work! Let me retest with a fix.

(In reply to comment #13) > (In reply to comment #12) > > (In reply to comment #9) > > > The menu bar still shows up in the titlebar if it's enabled via the menu > > > option. (the fx button goes away) > > > > Could this be a problem with nsXULElement::UnsetAttr in attachment 453280 [details] [diff] [review] [details]? > > Looks like aName wants to be nsGkAtoms::hidechrome and nsGkAtoms::chromemargin > > at the same time... > > That's definitely not going to work! Let me retest with a fix. That fixed it. Also, FWIW, I'm adding some chromemargin tests that will catch this and hopefully anything else. Need to check XP still, will report back.

This is a rather terrible experience to those who customised toolbars and moved anything to Menu Bar. It's now gone and there's no clear reason why. I guess the difference is between "removing menu" and "removing menu bar toolbar".

(In reply to comment #16) > This is a rather terrible experience to those who customised toolbars and moved > anything to Menu Bar. It's now gone and there's no clear reason why. > > I guess the difference is between "removing menu" and "removing menu bar > toolbar". What sort of things did you move there? I agree that we should have a better migration experience here.

(In reply to comment #17) > What sort of things did you move there? I agree that we should have a better > migration experience here. My goal was to use one toolbar - and since I couldn't move menu itself, I just brought everything I could to menu bar - back/forward/stop/reload buttons, followed by urlbar, followed by menu. Quick google suggests that there aren't any guides that advertise doing this, so perhaps my setup is unusual even among those who customise, and it doesn't matter. Perhaps a very simple migration path is to reset customised toolbars (all of them) is enough - there's so many changes everywhere that old customisations are no longer relevant.

https://litmus.mozilla.org/show_test.cgi?id=13616 added to Litmus.