Closed
Bug 575093
Opened 15 years ago
Closed 15 years ago
25% TXul regression from hiding the menu bar
Categories
(Core :: Widget: Win32, defect)
Tracking
()
RESOLVED
FIXED
mozilla2.0b1
Tracking | Status | |
---|---|---|
blocking2.0 | --- | final+ |
People
(Reporter: beltzner, Assigned: jimm)
References
Details
Reporter | ||
Updated•15 years ago
|
blocking2.0: --- → final+
Updated•15 years ago
|
Updated•15 years ago
|
OS: All → Windows 7
Reporter | ||
Comment 1•15 years ago
|
||
Resolved?
Improvement: Txul decrease 21.31% on Win7 Firefox
Previous results:
112.105 from build 20100628153205 of revision d4deb8d23c80 at 2010-06-28 16:35:00 on talos-r3-w7-022 run # 0
New results:
88.2105 from build 20100628161533 of revision 1265868dc033 at 2010-06-28 17:23:00 on talos-r3-w7-010 run # 0
http://mzl.la/bcQ5Mt
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=d4deb8d23c80&tochange=1265868dc033
Assignee | ||
Comment 2•15 years ago
|
||
(In reply to comment #1)
> Resolved?
>
> Improvement: Txul decrease 21.31% on Win7 Firefox
> Previous results:
> 112.105 from build 20100628153205 of revision d4deb8d23c80 at
> 2010-06-28 16:35:00 on talos-r3-w7-022 run # 0
> New results:
> 88.2105 from build 20100628161533 of revision 1265868dc033 at
> 2010-06-28 17:23:00 on talos-r3-w7-010 run # 0
> http://mzl.la/bcQ5Mt
>
> http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=d4deb8d23c80&tochange=1265868dc033
Good to see!
Comment 3•15 years ago
|
||
strange That should have not changed anything regarding that measure unless isElementVisible is damn slow
Comment 4•15 years ago
|
||
(In reply to comment #1)
> Resolved?
>
> Improvement: Txul decrease 21.31% on Win7 Firefox
> Previous results:
> 112.105 from build 20100628153205 of revision d4deb8d23c80 at
> 2010-06-28 16:35:00 on talos-r3-w7-022 run # 0
> New results:
> 88.2105 from build 20100628161533 of revision 1265868dc033 at
> 2010-06-28 17:23:00 on talos-r3-w7-010 run # 0
> http://mzl.la/bcQ5Mt
>
> http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=d4deb8d23c80&tochange=1265868dc033
Is the three to four per cent difference within the noise range?
Comment 5•15 years ago
|
||
(In reply to comment #4)
> Is the three to four per cent difference within the noise range?
looking at the graph on perftastic, it looks like all boxes are back to previous state.
Comment 6•15 years ago
|
||
Sounds like we can close this.
Not sure which bug solved this, but I think it was one of Jim's widget patches...
Assignee: nobody → jmathies
No longer blocks: 574435
Status: NEW → RESOLVED
Closed: 15 years ago
Component: General → Widget: Win32
Product: Firefox → Core
QA Contact: general → win32
Resolution: --- → FIXED
Updated•15 years ago
|
Target Milestone: --- → mozilla1.9.3b1
Comment 8•15 years ago
|
||
The range in comment 1 seems correct to me after comparing with the graph.
(In reply to comment #3)
> unless isElementVisible is damn slow
It triggers a flush, so it might well have impact.
Comment 9•15 years ago
|
||
makes sense, then it's the patch in bug 575218
Comment 10•15 years ago
|
||
I'm not sure I can follow. Which changeset regressed this if bug 575218 solved it?
Comment 11•15 years ago
|
||
The range points to http://hg.mozilla.org/mozilla-central/rev/beedc1e81d8f so this might be a fun interaction between those two things.
My completely uninformed guess is:
The menubar-hiding changeset set .hidden in cases where it didn't do so before, and this added a pending reflow request at a time where there wasn't any before. And then http://hg.mozilla.org/mozilla-central/rev/e6055b0ebd2a removed a flush, so the new pending reflow request is now coalesced with other layout changes that happen later and thus doesn't make a difference any more.
You need to log in
before you can comment on or make changes to this bug.
Description
•