Closed
Bug 578775
Opened 14 years ago
Closed 14 years ago
Change popups to menupopups and move them into popupsets in DOM Inspector
Categories
(Other Applications :: DOM Inspector, defect)
Other Applications
DOM Inspector
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: crussell, Assigned: crussell)
References
Details
Attachments
(1 file)
This is the DOM Inspector edition of bug 578440 and bug 572682.
The patch I had for this seemed to be causing many of the "Components is not defined" errors. I'll come back to it some other time and have a look, or someone else can take this if you don't want to wait.
Summary: Change popups to menupopups and move them into popupsets → Change popups to menupopups and move them into popupsets in DOM Inspector
Version: unspecified → Trunk
|
Assignee | |
Comment 2•14 years ago
|
||
I excluded the popup in browserOverlay.xul (see bug 578797). I also left out menu_ToolsPopup, which is supposed to be an overlay, but not all environments have it and so gets appended (see bug 346725).
|
||
Comment 3•14 years ago
|
||
Comment on attachment 460757 [details] [diff] [review]
popup to menupopup, with strays in popupsets; excludes browserOverlay.xul and menu_ToolsPopup [Checkin: comment 4]
>- <popup id="popupContext">
>- <menuitem label="&inspectNewWindow.label;" observes="cmdInspectInNewView"/>
>+ <menupopup id="popupContext">
>+ <menuitem label="&inspectNewWindow.label;"
>+ observes="cmdInspectInNewView"/>
81, how annoying ;-)
Attachment #460757 -
Flags: review?(neil) → review+
|
|
Assignee | |
Comment 4•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•14 years ago
|
Attachment #460757 -
Attachment description: popup to menupopup, with strays in popupsets; excludes browserOverlay.xul and menu_ToolsPopup → popup to menupopup, with strays in popupsets; excludes browserOverlay.xul and menu_ToolsPopup [Checkin: comment 4]
You need to log in
before you can comment on or make changes to this bug.
Description
•