Bug 563261 makes lwthemes installable and makes it work with browser on Windows and Linux, as I can't test on Mac, I can't see how it looks and works there, we need someone familiar with Mac to do it there.

I see problem with Bookmarks toolbar.

Of course you see a problem, as no work has been done in here yet. As I don't have a Mac, I can't work on this, as I can't test it. Help wanted!

(In reply to comment #1) > I see problem with Bookmarks toolbar. I can fix that, don't worry ;-) Can you see if there are any more issues? For example, do you think tab bar and tabs looks ok?

As I promissed yesterday I have a look at SeaMonkey on Mac OS X again. Problems: * Website navigation bar doesn't have Persona. * Tabbar doesn't have Persona on background.

Fixes all things reported here and some nits like tab borders and tab hover styling (needs to be re-visited when mailNews gets personas-friendly) A few comments: - hover:active on disabled linkToolbar items worked on disabled items (non-personas too) - I had to do some non-lwtheme changes in tabbrowser.css to make it work - I have some changes to sidebar too, but I'll wait with them since it needs more work

Once thing that I haven't solved in personas is that only some PT bookmark items gets their text-shadow changed on hover:active.

(In reply to comment #6) > Once thing that I haven't solved in personas is that only some PT bookmark > items gets their text-shadow changed on hover:active. Sorry, forget about that - this depends on the background!

Comment on attachment 460299 [details] [diff] [review] Make mac classic browser personas-friendly >-#linktoolbar > .bookmark-item:hover:active, >+#linktoolbar > .bookmark-item:not([disabled="true"]):hover:active, I guess this is really a separate bug ;-) >-.bookmark-item[container="true"]:hover:active { >+.bookmark-item:not([disabled="true"])[container="true"]:hover:active { Although I don't think bookmark items can be disabled, can they? >+.tabbrowser-tab[afterselected="true"]:-moz-lwtheme:-moz-locale-dir(ltr) { >+ -moz-border-left-colors: transparent transparent; >+} >+ >+.tabbrowser-tab[afterselected="true"]:-moz-lwtheme:-moz-locale-dir(rtl) { >+ -moz-border-right-colors: transparent transparent; >+} What styles are these overriding?

(In reply to comment #8) > Comment on attachment 460299 [details] [diff] [review] > Make mac classic browser personas-friendly > > >-#linktoolbar > .bookmark-item:hover:active, > >+#linktoolbar > .bookmark-item:not([disabled="true"]):hover:active, > I guess this is really a separate bug ;-) Right, OK. > > >-.bookmark-item[container="true"]:hover:active { > >+.bookmark-item:not([disabled="true"])[container="true"]:hover:active { > Although I don't think bookmark items can be disabled, can they? Well, the "Document" and "More" items in the linkToolbar are of class .bookmark-item ;-). I could add the rules there, of course. > > >+.tabbrowser-tab[afterselected="true"]:-moz-lwtheme:-moz-locale-dir(ltr) { > >+ -moz-border-left-colors: transparent transparent; > >+} > >+ > >+.tabbrowser-tab[afterselected="true"]:-moz-lwtheme:-moz-locale-dir(rtl) { > >+ -moz-border-right-colors: transparent transparent; > >+} > What styles are these overriding? Hmm, this must have been a leftover from me playing with the rules. I'll remove it.

I kept this, because it really affects personas -toolbarbutton.bookmark-item[disabled="true"], -toolbarbutton.bookmark-item[disabled="true"][container="true"] { +toolbarbutton.bookmark-item[disabled="true"] > .toolbarbutton-icon , +toolbarbutton.bookmark-item[disabled="true"][container="true"] > .toolbarbutton-icon { opacity: 0.5 !important; }

Comment on attachment 460643 [details] [diff] [review] New version > >-.tabbrowser-tab:-moz-locale-dir(ltr), >-.tabbrowser-tab:-moz-locale-dir(rtl):first-child { >+ >+.tabbrowser-tab:not([selected="true"]):-moz-locale-dir(ltr), >+.tabbrowser-tab:not([selected="true"]):-moz-locale-dir(rtl):first-child { Nit: extra blank line. > >+ And another.

Filed bug 582372 for the linkToolbar issue.

I forgot to address comment #11, so I pushed a another changeset (wrong bug # in comment...): http://hg.mozilla.org/comm-central/rev/69d97489bd8a