Closed
Bug 582372
Opened 14 years ago
Closed 14 years ago
[Mac default] hover:active style rules applies on disabled linkToolbar items
Categories
(SeaMonkey :: Themes, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.1b1
People
(Reporter: stefanh, Assigned: stefanh)
References
Details
Attachments
(1 file)
(deleted),
patch
|
mnyromyr
:
review+
neil
:
superreview+
|
Details | Diff | Splinter Review |
Spun off from bug 579737, comment #8: Since the hover:active style rules lacks :not([disabled="true"]), clicking a disabled item will apply the hover:active styles. I believe I caused this when I re-did mac classic.
Assignee | ||
Updated•14 years ago
|
Summary: [Mac default] Disabled linkToolbar items darkens upon hover:active → [Mac default] hover:active style rules applies on disabled linkToolbar items
Assignee | ||
Comment 1•14 years ago
|
||
One change might need some clarification: #bookmarks-button[open="true"], -.bookmark-item[container="true"]:hover:active { +.bookmark-item:not([disabled="true"])[container="true"]:hover:active { list-style-image: url("chrome://communicator/skin/bookmarks/bookmark-folder-active.png"); } These rules are in navigator.css and I think it's better to change them there than to duplicate them in linkToolbar.css
Attachment #463944 -
Flags: superreview?(neil)
Attachment #463944 -
Flags: review?(mnyromyr)
Assignee | ||
Updated•14 years ago
|
Status: NEW → ASSIGNED
Comment 2•14 years ago
|
||
Comment on attachment 463944 [details] [diff] [review] Fix hover:active styles >+#linktoolbar > .bookmark-item:not([disabled="true"])[container="true"]:hover:active { >+.bookmark-item:not([disabled="true"])[container="true"]:hover:active { I'd prefer .bookmark-item[container="true"]:not([disabled="true"]):hover:active
Attachment #463944 -
Flags: superreview?(neil) → superreview+
Assignee | ||
Updated•14 years ago
|
Target Milestone: seamonkey2.1a3 → seamonkey2.1b1
Comment 3•14 years ago
|
||
Comment on attachment 463944 [details] [diff] [review] Fix hover:active styles >+#link-top:not([disabled="true"]:hover:active >+#link-up:not([disabled="true"]:hover:active >+#link-first:not([disabled="true"]:hover:active >+#link-prev:not([disabled="true"]:hover:active >+#link-next:not([disabled="true"]:hover:active >+#link-last:not([disabled="true"]:hover:active Actually, I'd prefer rules not being applied because of their valid selector, not because the selector is broken. :-P Hint: ( love )... r=me with that fixed. (I tested a locally fixed version.)
Attachment #463944 -
Flags: review?(mnyromyr) → review+
Assignee | ||
Comment 4•14 years ago
|
||
Pushed with comment #2 and comment #3 addressed: http://hg.mozilla.org/comm-central/rev/bcc622bacd07
Assignee | ||
Updated•14 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•