Closed
Bug 580510
Opened 14 years ago
Closed 12 years ago
[fr] Update Amazon, eBay and Wikipedia logos for search plugins
Categories
(Mozilla Localizations :: fr / French, defect)
Mozilla Localizations
fr / French
Tracking
(firefox18 fixed, firefox19 fixed)
VERIFIED
FIXED
mozilla20
People
(Reporter: pascalc, Assigned: bugzilla.fr)
References
Details
(Keywords: polish, productization)
Attachments
(1 file)
(deleted),
image/png
|
Details |
The favicon for amazon.fr for Firefox 4 beta 2 has white artifacts around the A, the white pixels should probably be transparent, maybe we are using a gif image with no real transparency instead of png. This is very visible on a dark theme like Ubuntu's default, I don't know for other platforms but I believe Windows Seven also uses a dark theme and might be affected as well.
See screenshot.
Comment 1•14 years ago
|
||
Is this a regression against beta 1 or even 3.6.7?
Reporter | ||
Comment 2•14 years ago
|
||
This is not a regression, 3.6.7 also has a bad icon, I hadn't noticed before because the Linux distro version that I used does not ship with the amazon.fr search plugin but the en-US one which has a different favicon
(beta 1 was en-US only btw)
Comment 3•14 years ago
|
||
Thanks Pascal. Kev, is that an already known problem?
Comment 4•14 years ago
|
||
Sort of a dupe of bug 580510, I guess. New icons were provided in bug 421613, but they weren't updated in localized plugins.
Assignee: nobody → bugzilla.fr
Component: Search → fr / French
Product: Firefox → Mozilla Localizations
QA Contact: search → benoit.leseul
Version: Trunk → unspecified
Comment 5•14 years ago
|
||
Comment 6•14 years ago
|
||
what gavin said. what's in the en-US defaults is the icon Amazon has auth'd for distribution. if it's not changed in the locales, it should be on all current branches as soon as possible.
Keywords: productization
Comment 7•13 years ago
|
||
Pascal, can we close this bug?
Comment 8•12 years ago
|
||
The Amazon logo in the French build is not the same as the one in the en-US build.
Blocks: 421745
Comment 9•12 years ago
|
||
As well as Wikipedia & Ebay.
Is there any reason that would prevent me from taking those in en-US files to update fr?
Comment 10•12 years ago
|
||
I don't think so - I'd recommend you do exactly that!
Comment 11•12 years ago
|
||
(In reply to Théo Chevalier [:tchevalier] from comment #9)
> Wikipedia
French (map of the world) and en (W) Wikipedia search plugin logos were different at the beginning (bug 380785). I don't know why.
> Ebay.
It's a consequence of bug 812682.
Comment 12•12 years ago
|
||
Thanks! Amazon, eBay and Wikipedia icons updated across channels
http://hg.mozilla.org/l10n-central/fr/rev/4dffb010527a
http://hg.mozilla.org/releases/l10n/mozilla-aurora/fr/rev/bb98158842ac
http://hg.mozilla.org/releases/l10n/mozilla-beta/fr/rev/bfd24e0bc0ef
Comment 13•12 years ago
|
||
Guess we can close this bug
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment 14•12 years ago
|
||
Please always request review before landing changes to search plugins and region.properties, they're just too easy to get wrong.
Milos, can you do post-mortem reviews here?
Updated•12 years ago
|
Updated•12 years ago
|
Flags: needinfo?(milos)
Comment 15•12 years ago
|
||
Axel,
yep, as per https://bugzilla.mozilla.org/show_bug.cgi?id=421613 , this is postmortem r+.
Status: RESOLVED → VERIFIED
Flags: needinfo?(milos)
You need to log in
before you can comment on or make changes to this bug.
Description
•