Closed
Bug 812682
Opened 12 years ago
Closed 12 years ago
Updated eBay Logos for Desktop
Categories
(Firefox :: Search, defect)
Firefox
Search
Tracking
()
RESOLVED
FIXED
Firefox 20
People
(Reporter: jnagel, Assigned: ekw)
References
Details
(Whiteboard: [mentor=gavin])
Attachments
(4 files, 2 obsolete files)
(deleted),
image/png
|
Details | |
(deleted),
image/png
|
Details | |
(deleted),
image/png
|
Details | |
(deleted),
patch
|
Gavin
:
review+
lsblakk
:
approval-mozilla-aurora+
lsblakk
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
eBay has recently updated their Logo and request that we update the search drop-down with the new logos for Desktop & Mobile
Reporter | ||
Comment 1•12 years ago
|
||
Sorry, not sure how to upload batch files...
Reporter | ||
Comment 2•12 years ago
|
||
Comment 3•12 years ago
|
||
This is an easy one to pick-up: just a matter of pushing the 16x16 PNG through http://software.hixie.ch/utilities/cgi/data/data with the "base64" option selected, and then replacing the data: URI in the <Image> in http://mxr.mozilla.org/mozilla-central/source/browser/locales/en-US/searchplugins/eBay.xml with the result.
As far as I can tell, we don't have an eBay search for mobile, and bug 795495 isn't fixed yet, so we don't yet have use for the 32x32 version. The 16x16 ICO is a larger file for some reason (does it include both sizes?), so we probably don't need to use that.
Whiteboard: [mentor=gavin]
Updated•12 years ago
|
Attachment #682667 -
Attachment is obsolete: true
Updated•12 years ago
|
Summary: Updated eBay Logos for Desktop/Mobile → Updated eBay Logos for Desktop
Assignee | ||
Comment 4•12 years ago
|
||
Assignee | ||
Comment 5•12 years ago
|
||
Comment 6•12 years ago
|
||
Comment on attachment 684797 [details] [diff] [review]
Patch
Thanks, but I forgot to mention one thing - if you copy out of the Firefox URL bar, you'll get the escaped version, so you need to unescape that. Let's use this:
data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAYAAAAf8/9hAAABaklEQVQ4jc2TO0hbYQBGz42pMVDrINQuGvrCpZOSoQ4WoZoOxVk7FISCQxy6BEUtSIeCIBTsYCl0cHEQV0GU0lcIIkrpUEGNVYdi6qOtiTH+ubn3c4iTOPSaxbOfM30fkuokzUoy+n/MqVOHpDkP4lk+WpIMUM7FcCxJuqAMgK8U+dzAp5Us9QOr3gJm6RvbLRG2WyI4v3dIH7vcf7VO8/BP9jI2ZqGD3HQN6R/9zCz3AuCqwIeVIfwAf2L9BB+1ocwhtS96cBtGiPfdYnLxgMejmySivRSCtbDxlp3qML/+LbGfXSOV/l4MYNsEwo1cuXObTGcXgfEjynwWNdf8OPkDTLyVQNM0ztZ7Hoae8Tk5TM7+y5PwVDFQFXtO+vUb5LqkooNY1lUaXiaRxMTTIL7dB5hEO2U3u7lReQ+Y5O71CBX+KvC6nPmNMb2LN8sUDiVJl2MH+RJ8xwd8KSHwFRXvPCdvd86fOqETu2NuOELmXqEAAAAASUVORK5CYII=
Attachment #684797 -
Flags: review?(gavin.sharp) → feedback+
Assignee | ||
Comment 7•12 years ago
|
||
Unescaped Image data
Attachment #684797 -
Attachment is obsolete: true
Attachment #685382 -
Flags: review?(gavin.sharp)
Updated•12 years ago
|
Attachment #685382 -
Flags: review?(gavin.sharp) → review+
Comment 9•12 years ago
|
||
Keywords: checkin-needed
Comment 10•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
Comment 11•12 years ago
|
||
Comment 12•12 years ago
|
||
Comment on attachment 685382 [details] [diff] [review]
Patch
Joanne points out via email that it would be good to uplift this change to Aurora/Beta to avoid having to wait until Firefox 20. This is a trivial image swap, no risk and no string changes/etc.
Attachment #685382 -
Flags: approval-mozilla-beta?
Attachment #685382 -
Flags: approval-mozilla-aurora?
Updated•12 years ago
|
Attachment #685382 -
Flags: approval-mozilla-beta?
Attachment #685382 -
Flags: approval-mozilla-beta+
Attachment #685382 -
Flags: approval-mozilla-aurora?
Attachment #685382 -
Flags: approval-mozilla-aurora+
Updated•12 years ago
|
Keywords: checkin-needed
Comment 13•12 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/22925fa0b92b
https://hg.mozilla.org/releases/mozilla-beta/rev/8207d045d7e6
status-firefox18:
--- → fixed
status-firefox19:
--- → fixed
status-firefox20:
--- → fixed
Keywords: checkin-needed
Comment 14•12 years ago
|
||
Thanks Ryan!
Comment 15•12 years ago
|
||
The eBay logo for non en-US builds is not updated.
Comment 16•12 years ago
|
||
(In reply to Scoobidiver from comment #15)
> The eBay logo for non en-US builds is not updated.
Good catch, I had forgotten about those. We'll have to fix that in a followup, I filed bug 818328.
Comment 17•12 years ago
|
||
Guess you want this for comm-% and thunderbird, too?
Comment 18•12 years ago
|
||
"Want" is a strong word, I don't think there's a strong driver for comm-% and thunderbird to do anything (of course they're free to...).
Comment 19•12 years ago
|
||
Verified fixed on the latest beta, Firefox 18 beta 3.
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:18.0) Gecko/20100101 Firefox/18.0
Build ID: 20121205060959
Comment 20•12 years ago
|
||
Verified fixed on the latest beta, Firefox 20 beta 6. (Build ID: 20130320062118)
User Agent: Mozilla/5.0 (X11; Linux i686; rv:20.0) Gecko/20100101 Firefox/20.0
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:20.0) Gecko/20100101 Firefox/20.0
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:20.0) Gecko/20100101 Firefox/20.0
Updated•12 years ago
|
Comment 21•12 years ago
|
||
Setting this to verified, based on comment 20.
You need to log in
before you can comment on or make changes to this bug.
Description
•