Closed Bug 580870 Opened 14 years ago Closed 14 years ago

Alias gBrowser to the tabcandy context to remove getCurrentWindow

Categories

(Firefox Graveyard :: Panorama, defect)

Product:
Firefox Graveyard
Component:
Panorama
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: Mardak, Assigned: Mardak)

References

Details

Attachments

(1 file)

v1
(deleted), patch
iangilman
: feedback+
Details | Diff | Splinter Review
There's a number of calls to getCurrentWindow() that could be cached and stored as gWindow as that shouldn't change for a given tabcandy view in a browser window.
Attached patch v1 (deleted) — — Splinter Review
Assignee: nobody → edilee
Status: NEW → ASSIGNED
Attachment #459288 - Flags: review?(ian)
Attachment #459288 - Flags: feedback?(gavin.sharp)
Blocks: 580878
No longer blocks: 574217
Blocks: 580901
Blocks: 581052
Blocks: 581078
http://hg.mozilla.org/users/edward.lee_engineering.uiuc.edu/tabcandy-central/rev/41ec081e9f2c Add aliases for gWindow, gBrowser, gTabDeck, gTabFrame for the tabcandy chrome context. Update uses and simplify some code like removing Navbar.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Attachment #459288 - Flags: review?(ian) → feedback?(ian)
Comment on attachment 459288 [details] [diff] [review] v1 Mardak, this is awesome! Much cleaner. My only comment is that maybe gTabDeck and gTabFrame should be named so that it's clear that they refer to the Tab Candy UI (rather than the tab bar). Maybe gTabViewDeck?
Attachment #459288 - Flags: feedback?(ian) → feedback+
Mass moving all Tab Candy bugs from Mozilla Labs to Firefox::Tab Candy. Filter the bugmail spam with "tabcandymassmove".
Product: Mozilla Labs → Firefox
Target Milestone: -- → ---
Attachment #459288 - Flags: feedback?(gavin.sharp)
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: