Closed
Bug 581052
Opened 14 years ago
Closed 14 years ago
Don't grab Tabs[0] to get the tabbar for its tabs
Categories
(Firefox Graveyard :: Panorama, defect)
Firefox Graveyard
Panorama
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Mardak, Assigned: Mardak)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
iangilman
:
feedback+
|
Details | Diff | Splinter Review |
Also in reorderBasedOnTabOrder, it could be written in one line if it was still needed:
- var groupTabs = [];
- for ( var i=0; i<UI.tabBar.el.children.length; i++ ){
- var tab = UI.tabBar.el.children[i];
- if (!tab.collapsed)
- groupTabs.push(tab);
- }
+ let groupTabs = Array.filter(gBrowser.tabs, function(tab) !tab.collapsed);
|
Assignee | |
Comment 1•14 years ago
|
||
|
|
Assignee | |
Comment 2•14 years ago
|
||
cc: raymond re: _getAllTabs not being necessary to write the code to loop and push -> Array.slice()
|
|
Assignee | |
Comment 3•14 years ago
|
||
http://hg.mozilla.org/users/edward.lee_engineering.uiuc.edu/tabcandy-central/rev/99e3ad4e5f42
Just grab gBrowser.tabs to get an array-list of tabs instead of jumping through Tabs[0].raw.parentNode.children hoops.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•14 years ago
|
Attachment #459464 -
Flags: review?(ian) → feedback?(ian)
|
||
Comment 4•14 years ago
|
||
(In reply to comment #2)
> cc: raymond re: _getAllTabs not being necessary to write the code to loop and
> push -> Array.slice()
Great to know Array.slice(). BTW , the method wasn't written by me.
|
||
Comment 5•14 years ago
|
||
Comment on attachment 459464 [details] [diff] [review]
v1
looks good
Attachment #459464 -
Flags: feedback?(ian) → feedback+
|
||
Comment 6•14 years ago
|
||
Mass moving all Tab Candy bugs from Mozilla Labs to Firefox::Tab Candy. Filter the bugmail spam with "tabcandymassmove".
Product: Mozilla Labs → Firefox
Target Milestone: -- → ---
|
||
Updated•9 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•