User-Agent: Mozilla/5.0 (Windows; Windows NT 6.1; rv:2.0b3pre) Gecko/20100726 Minefield/4.0b3pre Build Identifier: Mozilla/5.0 (Windows; Windows NT 6.1; rv:2.0b3pre) Gecko/20100726 Minefield/4.0b3pre There's a userstyle that fixes this also. http://userstyles.org/styles/31911 Reproducible: Always

Should be fixed by the landings in bug 575870 & bug 574454.

Compared to this screenshot: https://wiki.mozilla.org/images/1/17/Firefox-4-Mockup-i06-%28Win7%29-%28Aero%29-%28TabsTop%29.png Current implementation has around 11-12 pixels difference between the Firefox button and the tabs and the mockup has 4-5 pixels. Is this intentional?

(In reply to comment #2) > Compared to this screenshot: > https://wiki.mozilla.org/images/1/17/Firefox-4-Mockup-i06-%28Win7%29-%28Aero%29-%28TabsTop%29.png > > Current implementation has around 11-12 pixels difference between the Firefox > button and the tabs and the mockup has 4-5 pixels. Is this intentional? The current titlebar respects your system metrics settings. So yes basically. The titlebar height should be the same as other app titlebars. There are some comparisons to notepad in bug 575870. If the UX folks want to tighten this up we can, we just have to decide how we'll handle custom ui settings. (see bug 576960 for reasons why.)

It actually looks good (like the mockup) when the browser window is maximized. I only see this bigger margin when the browser window is not maximized. The system buttons (minimize, maximize, close) doesn't seem to change size when maximized or not, so I don't get why the margin changes.

(In reply to comment #4) > It actually looks good (like the mockup) when the browser window is maximized. > I only see this bigger margin when the browser window is not maximized. > > The system buttons (minimize, maximize, close) doesn't seem to change size when > maximized or not, so I don't get why the margin changes. maximized windows don't have resizing border padding.

(In reply to comment #3) > The current titlebar respects your system metrics settings. So yes basically. > The titlebar height should be the same as other app titlebars. There are some > comparisons to notepad in bug 575870. > > If the UX folks want to tighten this up we can, we just have to decide how > we'll handle custom ui settings. (see bug 576960 for reasons why.) So this happening because of the actual height of the titlebar and not because of any margin or padding on our part?

(In reply to comment #6) > (In reply to comment #3) > > The current titlebar respects your system metrics settings. So yes basically. > > The titlebar height should be the same as other app titlebars. There are some > > comparisons to notepad in bug 575870. > > > > If the UX folks want to tighten this up we can, we just have to decide how > > we'll handle custom ui settings. (see bug 576960 for reasons why.) > > So this happening because of the actual height of the titlebar and not because > of any margin or padding on our part? Correct. I just posted some comparison shots in bug 574681 for reference.

Dupe/Depends on/Blocks ? bug 576952

fixed by https://bugzilla.mozilla.org/show_bug.cgi?id=575870#c99 ?

(In reply to comment #9) > fixed by https://bugzilla.mozilla.org/show_bug.cgi?id=575870#c99 ? It's fixed in maximized mode only. When not maximized, the gap is around 5px.

(In reply to comment #10) > It's fixed in maximized mode only. When not maximized, the gap is around 5px. I think it's fixed in not maximized mode. need more space in maximized mode.

It's not supposed to be 5px according to the mockups and that's too big anyways. 3 or 4px would look better.

This is theme, right? --> Firefox::Theme

This should be fixed or invalid since the titlebar patches landed in bug 575870. (We're discussion solutions to increase the margin in bug 574681.)

(In reply to comment #14) > This should be fixed or invalid since the titlebar patches landed in bug > 575870. > > (We're discussion solutions to increase the margin in bug 574681.) er, crap, *decrease* the margin.

(In reply to comment #15) > (In reply to comment #14) > > This should be fixed or invalid since the titlebar patches landed in bug > > 575870. > > > > (We're discussion solutions to increase the margin in bug 574681.) > > er, crap, *decrease* the margin. Reopening this as bug 574681 was specifically about fixing the appearance of the button but the margin issue still exists.

Dao filed bug 593950. I think that's a dupe of this, although he already posted a patch there.

(In reply to comment #17) > Dao filed bug 593950. I think that's a dupe of this, although he already posted > a patch there. Ok closing again then :)