Closed
Bug 583742
Opened 14 years ago
Closed 6 years ago
No way to disable the JIT via the x-platform configure script
Categories
(Tamarin Graveyard :: Build Config, defect, P4)
Tamarin Graveyard
Build Config
Tracking
(Not tracked)
RESOLVED
WONTFIX
Q2 12 - Cyril
People
(Reporter: brbaker, Assigned: brbaker)
References
Details
Attachments
(1 file)
(deleted),
patch
|
edwsmith
:
review-
|
Details | Diff | Splinter Review |
Currently the only way to NOT enable the JIT when compiling the shell is to enable the wordcode interpreter. There used to be an option of disabling the JIT that was independent of interpreter implementation. '--disable-jit' would set -AVMFEATURE_JIT=0
The --disable-jit switch was lost in tamarin-redux rev#2502
http://hg.mozilla.org/tamarin-redux/rev/15b85ac876bb
Flags: flashplayer-triage+
Flags: flashplayer-qrb?
Assignee | ||
Comment 1•14 years ago
|
||
--disable-jit will now set -DAVMFEATURE_JIT=0
Attachment #462079 -
Flags: review?(edwsmith)
Comment 2•14 years ago
|
||
Comment on attachment 462079 [details] [diff] [review]
./configure.py --disable-jit now works
avmfeatures.py is generated by avmfeatures.as. The bug is probably in how avmfeatures.as generates avmfeatures.py (why doesn't it generate the full sequence that tests for arg==True and arg==False?)
The bug could also be that we aren't expressing the mutual exclusion properly. we have an <at-most-one> clause to make jit and wordcode mutually exclusive, but the other way to express it would have been some <precludes> tags in each feature.
Attachment #462079 -
Flags: review?(edwsmith) → review-
Comment 3•14 years ago
|
||
There are some known (possibly recorded) bugs in how the feature system handles generation of switches for the batch build scripts, due to the feature system not knowing what the defaults are for everything controlled by the batch build script. If everything defaulted to False it would be easy, but that's not the case.
If the feature system does not handle mutexing correctly then we should fix that...
Updated•14 years ago
|
Assignee: nobody → brbaker
Status: NEW → ASSIGNED
Flags: flashplayer-qrb? → flashplayer-qrb+
Target Milestone: --- → flash10.2
Assignee | ||
Updated•14 years ago
|
Comment 4•14 years ago
|
||
changeset: 5639:0764d3076093
user: Brent Baker <brbaker@adobe.com>
summary: Bug 583742: remove the building of the shell with no jit until the --disable-jit switch in the x-compile script is working (r=brbaker)
http://hg.mozilla.org/tamarin-redux/rev/0764d3076093
Assignee | ||
Comment 5•14 years ago
|
||
When this issue is resolved need to rollback changeset 5639:0764d3076093
Comment 6•14 years ago
|
||
Is this now a feature system bug?
Updated•13 years ago
|
Target Milestone: Q3 11 - Serrano → Q4 11 - Anza
Comment 7•12 years ago
|
||
I think this is likely to get fixed by the patch I have proposed for Bug 779995.
Updated•6 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•