Closed Bug 587629 Opened 14 years ago Closed 14 years ago

Removal of document.height broke automatic scrolling

Categories

(Other Applications :: ChatZilla, defect)

defect
Not set
major

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: neil, Assigned: glenjamin+bmo)

References

Details

(Keywords: useless-UI, Whiteboard: [cz-0.9.87][tracking-seamonkey-2.2+])

Attachments

(1 file)

Chatzilla has apparently been using window.document.height since the dawn of time in order to scroll the document to the end. As far as I can tell it would have used window.scrollMaxY instead, but that had to wait another two years before it was invented.
To retain backward compatibility from before window.scrollMaxY was created, it would be possible to switch to window.document.body.clientHeight instead (this results in a figure equal to window.document.height).
It appears the removal was deemed hasty, and got backed out. Do we still care about this?
Well, not for Firefox 4, but might still get removed from Firefox 4.next...
I'm planning to reland it this or next week. I'd suggest you do care.
I don't have a dev env at the moment, or this would be a patch, but to save people the trouble of tracking down the MXR section which actually contains chatzilla these days, the offending lines are: http://mxr.mozilla.org/comm-central/search?string=document.height&find=%2Fmozilla%2Fextensions%2Firc%2F&findi=&filter=^[^\0]*%24&hitlimit=&tree=comm-central Should be a nice easy fix, will get to it midweek if someone else hasn't already.
I see this bug on SeaMonkey trunk nightlies starting 2011-04-18. Without scrolling, every tab's content is empty except for the tab name in the middle. Bumping Severity to major. I've gone back to the last good nightly, to wit: Mozilla/5.0 (X11; Linux x86_64; rv:6.0a1) Gecko/20110417 Firefox/6.0a1 SeaMonkey/2.2a1pre ID:20110417003006
Severity: normal → major
Keywords: useless-UI
Whiteboard: [tracking-seamonkey-2.2+]
Tested in firefox 4.0, also checked for existance of document.body.clientHeight on mozilla 1.0
Assignee: rginda → glenjamin+bmo
Status: NEW → ASSIGNED
Attachment #527334 - Flags: review?(silver)
Attachment #527334 - Flags: review?(silver) → review+
Version: unspecified → Trunk
Any chance to get this fixed? (I have to stick with Fx4 until Chatzilla works with trunk.)
I wonder if I have access rights to http://hg.mozilla.org/chatzilla. If I do, I could push the patch.
http://hg.mozilla.org/chatzilla/rev/5cad0d08447e I forgot to set the revision author, but that's what you get for forcing my hand.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Mozilla/5.0 (X11; Linux x86_64; rv:7.0a1) Gecko/20110526 Firefox/7.0a1 SeaMonkey/2.2a1pre ID:20110526003005 Autoscrolling to the bottom of ChatZilla tabs has indeed reappeared => VERIFIED. Attention, SeaMonkey users: Due to the manner in which ChatZilla is packaged with SeaMonkey, if you have been using your profile with SeaMonkey 2.2a1pre builds made shortly before the fix, the new ChatZilla version will not automatically be used. You may need to do the following after updating to some SeaMonkey 2.2a1pre build later than comment #11: 1. Browse to about:config (if said that this could void your warranty, answer that you'll be careful), and find the preference extensions.lastAppVersion. It should say "user set 2.2a1pre". 2. Double-click on it and change it to some lower value, let's say 2.2a0 3. Restart SeaMonkey. On restart, SeaMonkey should check your extensions for compatibility. After that, you should see that extensions.lastAppVersion has reverted to 2.2a1pre and that when you start ChatZilla, it says "ChatZilla 0.9.87" at top center of the client tab and autoscrolling is working again.
Status: RESOLVED → VERIFIED
Whiteboard: [tracking-seamonkey-2.2+] → [cz-0.9.87][tracking-seamonkey-2.2+]
Blocks: 665850
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: