Gregor Wagner [:gwagner] Assignee
	Description • 14 years ago

      No description provided.

	Andreas Gal :gal
	Comment 2 • 14 years ago

Comment on attachment 471774 [details] [diff] [review]
patch

Looks good. This is all rather harmless finalization stuff and xpcshell so I will +.

	Blake Kaplan (:mrbkap) (inactive)
	Comment 3 • 14 years ago

Comment on attachment 471774 [details] [diff] [review]
patch

>diff -r 8771ed0c60d8 js/src/xpconnect/shell/xpcshell.cpp
>--- a/js/src/xpconnect/shell/xpcshell.cpp	Thu Sep 02 14:52:18 2010 -0700
>+++ b/js/src/xpconnect/shell/xpcshell.cpp	Thu Sep 02 14:56:20 2010 -0700
>@@ -1963,17 +1963,17 @@ main(int argc, char **argv)
> 
>         rv = holder->GetJSObject(&glob);
>         if (NS_FAILED(rv)) {
>             NS_ASSERTION(glob == nsnull, "bad GetJSObject?");
>             return 1;
>         }
> 
>         JS_BeginRequest(cx);
>-
>+        JSAutoEnterCompartment ac(cx, glob);
>         if (!JS_DefineFunctions(cx, glob, glob_functions)) {

Doesn't this want to be an AutoCrossCompartmentCall?

	Andreas Gal :gal
	Comment 4 • 14 years ago

Can't hurt. Gregor want to change that?

	Gregor Wagner [:gwagner] Assignee
	Comment 5 • 14 years ago

I had to scope the JSAutoCrossCompartmentCall otherwise it asserts during deconstruction because there is no more context.

	Gregor Wagner [:gwagner] Assignee
	Comment 6 • 14 years ago

review ping

	Andreas Gal :gal
	Comment 7 • 14 years ago

Comment on attachment 471932 [details] [diff] [review]
patch

Undo the unrelated indentation changes please.

	Gregor Wagner [:gwagner] Assignee
	Comment 8 • 14 years ago

http://hg.mozilla.org/tracemonkey/rev/0fadb2696554

	Chris Leary [:cdleary] (not checking bugmail)
	Comment 10 • 14 years ago

http://hg.mozilla.org/mozilla-central/rev/0fadb2696554