Gregor Wagner [:gwagner] Assignee
	Description • 14 years ago

      No description provided.

	Gregor Wagner [:gwagner] Assignee
	Comment 1 • 14 years ago

Asserting at the API boundary that we don't enter with the defaultCompartment.

	Jason Orendorff [:jorendorff]
	Comment 2 • 14 years ago

Gregor, I think the assertion in JS_IsAboutToBeCollected is bogus. Please rip that out and later today I'll remove any JSAutoCrossCompartmentCalls we've added in GC callbacks.

	Jason Orendorff [:jorendorff]
	Comment 3 • 14 years ago

Hope everyone agrees this isn't a productive thing to be doing.

	Gregor Wagner [:gwagner] Assignee
	Comment 4 • 14 years ago

refresh of api asserts:
JS_ASSERT(cx->compartment != cx->runtime->defaultCompartment);

	Gregor Wagner [:gwagner] Assignee
	Comment 5 • 14 years ago

I pass now all the xpcshell tests on my machine (Mac) with all the various defaultCompartment fixes. 
Tryserver for windows and linux indicates another mixup in 
TEST-INFO | e:\builds\moz2_slave\tryserver-win32-debug-unittest-xpcshell\build\xpcshell\tests\chrome\test\unit_ipc\test_resolve_uris_ipc.js |

It looks like the last one :)

	Andreas Gal :gal
	Comment 6 • 14 years ago

file it, I can fix

	Gregor Wagner [:gwagner] Assignee
	Comment 7 • 14 years ago

I pushed the API assertion patch to tryserver and I don't see assertions any more.

Looks like we fixed all defaultCompartment mixups that are covered by the testcases!

	Gregor Wagner [:gwagner] Assignee
	Comment 8 • 14 years ago

Maybe we should land some assertions in jsapi for the future.

	Jason Orendorff [:jorendorff]
	Comment 9 • 14 years ago

Comment on attachment 479972 [details] [diff] [review]
patch

The original idea was that non-JS_THREADSAFE embeddings could ignore compartments entirely and use the default compartment for everything. That way we only break JS_THREADSAFE embedders.

If you think that would work, please make the asserts JS_THREADSAFE-only.  (I think all JS_THREADSAFE embeddings will want to avoid the default compartment for the same reasons we do.)

r=me with that.

	Gregor Wagner [:gwagner] Assignee
	Comment 10 • 14 years ago

Something like this with JS_THREADSAFE_ASSERT?

	Robert Sayre
	Comment 11 • 14 years ago

http://hg.mozilla.org/mozilla-central/rev/1283831c28bf