Closed
Bug 595066
Opened 14 years ago
Closed 14 years ago
Sync UI: Ask for email address instead of username
Categories
(Firefox :: Sync, defect)
Firefox
Sync
Tracking
()
VERIFIED
FIXED
Tracking | Status | |
---|---|---|
blocking2.0 | --- | beta7+ |
People
(Reporter: philikon, Assigned: philikon)
References
Details
(Whiteboard: [strings] [testday-9-24-2010])
Attachments
(1 file, 3 obsolete files)
(deleted),
patch
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #589979 +++
Instead of having to enter both username and email address on sign-up, users should only be required to provide the email address.
Assignee | ||
Comment 1•14 years ago
|
||
Pretty much equivalent to Bug 589979 Part 3.
Assignee: nobody → philipp
Attachment #473943 -
Flags: review?(mconnor)
Assignee | ||
Comment 2•14 years ago
|
||
Also update error messages mentioning user name (now mention email address
where appropriate).
Attachment #473943 -
Attachment is obsolete: true
Attachment #474213 -
Flags: review?(mconnor)
Attachment #473943 -
Flags: review?(mconnor)
Assignee | ||
Updated•14 years ago
|
blocking2.0: --- → ?
Whiteboard: [strings]
Comment 3•14 years ago
|
||
Comment on attachment 474213 [details] [diff] [review]
v2
>+ onEmailChange: function () {
>+ //XXXzpao Not sure about this regex. Look into it in followup (bug 583650)
>+ let value = document.getElementById("weaveEmail").value;
this comment should die, and we should resolve that bug. It's in the wrong place here, in any case.
>- let error = Weave.Service.createAccount(username, password, email,
>+ let error = Weave.Service.createAccount(email, password, email,
> challenge, response);
Should we change the signature of createAccount? as a followup, I think.
Attachment #474213 -
Flags: review?(mconnor) → review+
Assignee | ||
Comment 4•14 years ago
|
||
Address review comments
Attachment #474213 -
Attachment is obsolete: true
Assignee | ||
Comment 5•14 years ago
|
||
(In reply to comment #3)
> Should we change the signature of createAccount? as a followup, I think.
I wasn't sure myself and left it like this for now, mostly also for backwards compat reasons. Filed bug 595879 as a followup.
Updated•14 years ago
|
Assignee: philipp → nobody
Component: General → Firefox Sync: UI
Product: Firefox → Mozilla Services
QA Contact: general → sync-ui
Version: Trunk → unspecified
Updated•14 years ago
|
blocking2.0: ? → beta7+
Updated•14 years ago
|
Assignee: nobody → philipp
Assignee | ||
Comment 6•14 years ago
|
||
Rebase on top of fixes from bug 596093.
Attachment #474708 -
Attachment is obsolete: true
Assignee | ||
Comment 7•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Comment 8•14 years ago
|
||
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b7pre) Gecko/20100924 Firefox/4.0b7pre
Status: RESOLVED → VERIFIED
Whiteboard: [strings] → [strings] [testday-9-24-2010]
Updated•6 years ago
|
Component: Firefox Sync: UI → Sync
Product: Cloud Services → Firefox
You need to log in
before you can comment on or make changes to this bug.
Description
•